Stream: git-wasmtime

Topic: wasmtime / PR #7679 wasi-nn: adapt to new test infrastruc...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2023 at 01:47):

abrown requested pchickey for a review on PR #7679.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2023 at 01:47):

abrown requested wasmtime-core-reviewers for a review on PR #7679.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2023 at 01:47):

abrown opened PR #7679 from abrown:nn-test-infrastructure to bytecodealliance:main:

This is a modern refactoring of #6895 to make wasi-nn use the test infrastructure that other WASI proposals are using (i.e., crates/test-programs). This is only the beginning: in follow up PRs, wasi-nn could gain unit tests, the existing examples could be removed, more kinds of tests could be added, etc. This will be easier in the future, though, once this infrastructure is in place for the wasmtime-wasi-nn crate.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2023 at 01:47):

abrown requested wasmtime-default-reviewers for a review on PR #7679.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2023 at 01:50):

abrown updated PR #7679.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2023 at 02:32):

abrown updated PR #7679.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2023 at 16:09):

abrown updated PR #7679.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2023 at 18:17):

abrown updated PR #7679.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 13 2023 at 23:04):

abrown updated PR #7679.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 14 2023 at 23:40):

abrown updated PR #7679.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 15 2023 at 01:06):

abrown updated PR #7679.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 15 2023 at 01:34):

abrown updated PR #7679.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 15 2023 at 01:40):

abrown updated PR #7679.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 15 2023 at 02:18):

abrown updated PR #7679.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 15 2023 at 05:35):

abrown has marked PR #7679 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 15 2023 at 16:16):

alexcrichton submitted PR review:

Thanks! This is replacing the preexisting wasi-nn test, right? Would it make sense to delete that from CI while here?

view this post on Zulip Wasmtime GitHub notifications bot (Dec 15 2023 at 22:15):

abrown updated PR #7679.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 15 2023 at 22:17):

abrown updated PR #7679.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 15 2023 at 23:05):

abrown has enabled auto merge for PR #7679.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 15 2023 at 23:47):

abrown merged PR #7679.

Last updated: Nov 22 2024 at 17:03 UTC