Wasmtime GitHub notifications bot (Dec 08 2023 at 17:10): Wasmtime GitHub notifications bot (Dec 08 2023 at 17:10):alexcrichton opened PR #7661 from alexcrichton:reserve-index-zero to bytecodealliance:main:
This commit updates the allocation scheme for resources in the component model to start at 1 instead of 0 when communicating with components. This is an implementation of WebAssembly/component-model#284.
While this broke a number of tests we have this shouldn't actually break any components in practice. The broken tests were all overly-precise in their assertions and error messages and this shouldn't idiomatically come up in any guest language, so this should not be a practically breaking change.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 08 2023 at 17:10):alexcrichton requested pchickey for a review on PR #7661.
Wasmtime GitHub notifications bot (Dec 08 2023 at 17:10):alexcrichton requested wasmtime-core-reviewers for a review on PR #7661.
Wasmtime GitHub notifications bot (Dec 08 2023 at 17:15):alexcrichton updated PR #7661.
Wasmtime GitHub notifications bot (Dec 08 2023 at 17:33):rylev submitted PR review.
Wasmtime GitHub notifications bot (Dec 08 2023 at 17:33):rylev submitted PR review.
Wasmtime GitHub notifications bot (Dec 08 2023 at 17:33):rylev created PR review comment:
Nit: can the upper limit be moved to a constant and perhaps link to the spec where it is specified?
Wasmtime GitHub notifications bot (Dec 08 2023 at 17:33):rylev created PR review comment:
The fetching of a slot is finicky enough that I wonder if it makes sense to move it to its own function so if there is ever another need for that logic the chances of bad copy/paste can be minimized.
Wasmtime GitHub notifications bot (Dec 08 2023 at 19:45):github-actions[bot] commented on PR #7661:
Subscribe to Label Action
cc @peterhuene
<details>
This issue or pull request has been labeled: "wasmtime:api"Thus the following users have been cc'd because of the following labels:
- peterhuene: wasmtime:api
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Feb 21 2024 at 15:53):alexcrichton updated PR #7661.
Wasmtime GitHub notifications bot (Feb 21 2024 at 15:54):alexcrichton commented on PR #7661:
Oops it appears that I forgot about this, so I've now rebased this and this should be ready again after addressing @rylev's comments.
Wasmtime GitHub notifications bot (Feb 21 2024 at 18:00):pchickey submitted PR review:
Thanks, I also forgot all about this
Wasmtime GitHub notifications bot (Feb 21 2024 at 18:32):alexcrichton merged PR #7661.
Last updated: Nov 22 2024 at 16:03 UTC