Stream: git-wasmtime

Topic: wasmtime / PR #7658 Replace clap attributes with command ...

view this post on Zulip Wasmtime GitHub notifications bot (Dec 08 2023 at 10:44):

iawia002 requested elliottt for a review on PR #7658.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 08 2023 at 10:44):

iawia002 requested pchickey for a review on PR #7658.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 08 2023 at 10:44):

iawia002 requested wasmtime-core-reviewers for a review on PR #7658.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 08 2023 at 10:44):

iawia002 requested wasmtime-compiler-reviewers for a review on PR #7658.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 08 2023 at 10:44):

iawia002 opened PR #7658 from iawia002:clap-cleanup to bytecodealliance:main:

While reading the code, I noticed that we were mixing clap's clap, command, arg, and structopt attributes, and it seemed quite messy, and even though #[clap()] still works, #[arg()] and #[command()] are now recommended since clap v4, ref https://github.com/clap-rs/clap/pull/4180.

So this patch standardizes them, eliminating the use of outdated clap attributes and removing some meaningless name configurations.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 08 2023 at 10:46):

iawia002 submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 08 2023 at 10:46):

iawia002 created PR review comment:

This actually won't work, if we want to change the name, we need to config it in https://github.com/bytecodealliance/wasmtime/blob/3b61c511a0b152d2bb40343b87b5fb1e70a87564/src/bin/wasmtime.rs#L49C1-L51

view this post on Zulip Wasmtime GitHub notifications bot (Dec 08 2023 at 10:54):

iawia002 updated PR #7658.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 08 2023 at 12:49):

github-actions[bot] commented on PR #7658:

Subscribe to Label Action

cc @cfallin, @fitzgen, @saulecabrera

<details>
This issue or pull request has been labeled: "cranelift", "isle", "winch"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Dec 08 2023 at 16:19):

alexcrichton submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Dec 08 2023 at 16:59):

alexcrichton merged PR #7658.

Last updated: Dec 23 2024 at 12:05 UTC