Wasmtime GitHub notifications bot (Dec 06 2023 at 22:03): Wasmtime GitHub notifications bot (Dec 06 2023 at 22:03):alexcrichton requested elliottt for a review on PR #7651.
Wasmtime GitHub notifications bot (Dec 06 2023 at 22:03):alexcrichton opened PR #7651 from alexcrichton:increase-stack-size to bytecodealliance:main:
This commit is an attempt to address the CI failure popping up in #7636. I can reproduce the failure locally and it appears to be due to the fact that macOS is giving spawned threads via
pthread_createa 512K stack by default. Cranelift when compiled in debug mode is taking more stack than this (but working in release mode). I was talking with Trevor and Jamey about possible ways to reduce the stack size here but for now I'm going with Jamey's suggestion of increasing the stack size as the best course of action for now.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 06 2023 at 22:03):alexcrichton requested pchickey for a review on PR #7651.
Wasmtime GitHub notifications bot (Dec 06 2023 at 22:03):alexcrichton requested wasmtime-core-reviewers for a review on PR #7651.
Wasmtime GitHub notifications bot (Dec 06 2023 at 22:07):elliottt submitted PR review:
Looks good to me! It's also nice that we'll use 2MB across all platforms for this test now, instead of allowing for varying defaults.
Wasmtime GitHub notifications bot (Dec 06 2023 at 22:08):alexcrichton has enabled auto merge for PR #7651.
Wasmtime GitHub notifications bot (Dec 06 2023 at 22:55):alexcrichton merged PR #7651.
Last updated: Nov 22 2024 at 16:03 UTC