Wasmtime GitHub notifications bot (Dec 04 2023 at 17:17): Wasmtime GitHub notifications bot (Dec 04 2023 at 17:17):saulecabrera requested elliottt for a review on PR #7628.
Wasmtime GitHub notifications bot (Dec 04 2023 at 17:17):saulecabrera opened PR #7628 from saulecabrera:winch-rework-br-table to bytecodealliance:main:
Follow up to: https://github.com/bytecodealliance/wasmtime/pull/7616
The fuzzer has been running for a while now (~2 days) without reporting new issues.
This commit reworks the
br_tablelogic so that it correctly handles all the jumps involved to each of the targets.Even though it is safe to use the default branch for type information, it is not safe to use it to derive the base stack pointer and base value stack length. Each block might and will probably have, different values as base stack pointer and base value stack length. This change ensures that each target offset is taken into account to balance the value stack prior to each jump.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 04 2023 at 17:17):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #7628.
Wasmtime GitHub notifications bot (Dec 04 2023 at 17:31):saulecabrera requested alexcrichton for a review on PR #7628.
Wasmtime GitHub notifications bot (Dec 04 2023 at 17:31):saulecabrera requested wasmtime-core-reviewers for a review on PR #7628.
Wasmtime GitHub notifications bot (Dec 04 2023 at 17:31):saulecabrera updated PR #7628.
Wasmtime GitHub notifications bot (Dec 04 2023 at 17:45):github-actions[bot] commented on PR #7628:
Subscribe to Label Action
cc @saulecabrera
<details>
This issue or pull request has been labeled: "winch"Thus the following users have been cc'd because of the following labels:
- saulecabrera: winch
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Dec 05 2023 at 07:26):elliottt submitted PR review:
I think this makes sense, thank you for all the additional fuzzing!
Wasmtime GitHub notifications bot (Dec 05 2023 at 11:03):saulecabrera merged PR #7628.
Last updated: Dec 23 2024 at 12:05 UTC