Stream: git-wasmtime

Topic: wasmtime / PR #7625 Make `fields.get` return an option


view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2023 at 00:22):

elliottt requested wasmtime-core-reviewers for a review on PR #7625.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2023 at 00:22):

elliottt opened PR #7625 from elliottt:trevor/wasi-http-fields-get to bytecodealliance:main:

As discussed in https://github.com/WebAssembly/wasi-http/issues/82, it would be nice to be able to know when a header value exists, vs when it's empty.
<!--
Please make sure you include the following information:

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2023 at 00:22):

elliottt requested alexcrichton for a review on PR #7625.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2023 at 01:02):

elliottt requested pchickey for a review on PR #7625.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 04 2023 at 15:29):

alexcrichton submitted PR review:

Looks reasonable to me, but @pchickey should sign-off on this as well

view this post on Zulip Wasmtime GitHub notifications bot (Dec 04 2023 at 19:43):

alexcrichton commented on PR #7625:

Also, should this also be sent upstream to WebAssembly/wasi-http?

view this post on Zulip Wasmtime GitHub notifications bot (Dec 04 2023 at 19:47):

elliottt commented on PR #7625:

Also, should this also be sent upstream to WebAssembly/wasi-http?

Yes, I'll make that pr as well. Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Dec 04 2023 at 19:52):

elliottt commented on PR #7625:

Upstream pr: https://github.com/WebAssembly/wasi-http/pull/91


Last updated: Dec 23 2024 at 12:05 UTC