Wasmtime GitHub notifications bot (Dec 02 2023 at 00:22): Wasmtime GitHub notifications bot (Dec 02 2023 at 00:22):elliottt requested wasmtime-core-reviewers for a review on PR #7625.
Wasmtime GitHub notifications bot (Dec 02 2023 at 00:22):elliottt opened PR #7625 from elliottt:trevor/wasi-http-fields-get to bytecodealliance:main:
As discussed in https://github.com/WebAssembly/wasi-http/issues/82, it would be nice to be able to know when a header value exists, vs when it's empty.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Dec 02 2023 at 00:22):elliottt requested alexcrichton for a review on PR #7625.
Wasmtime GitHub notifications bot (Dec 02 2023 at 01:02):elliottt requested pchickey for a review on PR #7625.
Wasmtime GitHub notifications bot (Dec 04 2023 at 15:29):alexcrichton submitted PR review:
Looks reasonable to me, but @pchickey should sign-off on this as well
Wasmtime GitHub notifications bot (Dec 04 2023 at 19:43):alexcrichton commented on PR #7625:
Also, should this also be sent upstream to WebAssembly/wasi-http?
Wasmtime GitHub notifications bot (Dec 04 2023 at 19:47):elliottt commented on PR #7625:
Also, should this also be sent upstream to WebAssembly/wasi-http?
Yes, I'll make that pr as well. Thanks!
Wasmtime GitHub notifications bot (Dec 04 2023 at 19:52):elliottt commented on PR #7625:
Upstream pr: https://github.com/WebAssembly/wasi-http/pull/91
Last updated: Nov 22 2024 at 16:03 UTC