Stream: git-wasmtime

Topic: wasmtime / PR #7609 mpk: add an example testing the memor...


view this post on Zulip Wasmtime GitHub notifications bot (Nov 29 2023 at 21:13):

abrown edited PR #7609.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 29 2023 at 21:27):

alexcrichton commented on PR #7609:

The bytesize crate looks vet-able relatively easily but looks like proc-maps is a pretty heavyweight dependency pulling in quite a lot. Could that dependency be dropped in favor of parsing /proc/self/maps manually?

view this post on Zulip Wasmtime GitHub notifications bot (Nov 29 2023 at 21:41):

alexcrichton submitted PR review:

Neat! I like having little example programs like this.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 29 2023 at 21:41):

alexcrichton submitted PR review:

Neat! I like having little example programs like this.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 29 2023 at 21:41):

alexcrichton created PR review comment:

Since this is the start of the program this can actually be env_logger::init()

view this post on Zulip Wasmtime GitHub notifications bot (Nov 29 2023 at 21:41):

alexcrichton created PR review comment:

You may want to note here that this documentation only applies to Linux. You may also want to note that MPK only works on Linux too here (in case anyone lands here first)

view this post on Zulip Wasmtime GitHub notifications bot (Nov 29 2023 at 21:45):

github-actions[bot] commented on PR #7609:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config"

Thus the following users have been cc'd because of the following labels:

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

view this post on Zulip Wasmtime GitHub notifications bot (Nov 29 2023 at 21:45):

github-actions[bot] commented on PR #7609:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html


<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

view this post on Zulip Wasmtime GitHub notifications bot (Dec 01 2023 at 00:21):

abrown updated PR #7609.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 01 2023 at 00:26):

abrown has marked PR #7609 as ready for review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 01 2023 at 00:26):

abrown requested pchickey for a review on PR #7609.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 01 2023 at 00:26):

abrown requested wasmtime-core-reviewers for a review on PR #7609.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 01 2023 at 00:26):

abrown requested wasmtime-default-reviewers for a review on PR #7609.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 01 2023 at 18:27):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 01 2023 at 21:57):

abrown updated PR #7609.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 01 2023 at 21:58):

abrown has enabled auto merge for PR #7609.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 01 2023 at 22:54):

abrown updated PR #7609.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 01 2023 at 22:54):

abrown has enabled auto merge for PR #7609.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2023 at 00:30):

abrown updated PR #7609.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2023 at 00:30):

abrown has enabled auto merge for PR #7609.

view this post on Zulip Wasmtime GitHub notifications bot (Dec 02 2023 at 01:19):

abrown merged PR #7609.


Last updated: Dec 23 2024 at 13:07 UTC