Stream: git-wasmtime

Topic: wasmtime / PR #7609 mpk: add an example testing the memor...

Wasmtime GitHub notifications bot (Nov 29 2023 at 21:13):

abrown edited PR #7609.

Wasmtime GitHub notifications bot (Nov 29 2023 at 21:27):

alexcrichton commented on PR #7609:

The bytesize crate looks vet-able relatively easily but looks like proc-maps is a pretty heavyweight dependency pulling in quite a lot. Could that dependency be dropped in favor of parsing /proc/self/maps manually?

Wasmtime GitHub notifications bot (Nov 29 2023 at 21:41):

alexcrichton submitted PR review:

Neat! I like having little example programs like this.

Wasmtime GitHub notifications bot (Nov 29 2023 at 21:41):

alexcrichton submitted PR review:

Neat! I like having little example programs like this.

Wasmtime GitHub notifications bot (Nov 29 2023 at 21:41):

alexcrichton created PR review comment:

Since this is the start of the program this can actually be env_logger::init()

Wasmtime GitHub notifications bot (Nov 29 2023 at 21:41):

alexcrichton created PR review comment:

You may want to note here that this documentation only applies to Linux. You may also want to note that MPK only works on Linux too here (in case anyone lands here first)

Wasmtime GitHub notifications bot (Nov 29 2023 at 21:45):

github-actions[bot] commented on PR #7609:

Subscribe to Label Action

cc @peterhuene

<details>
This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config"

Thus the following users have been cc'd because of the following labels:

• peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.

Learn more.
</details>

Wasmtime GitHub notifications bot (Nov 29 2023 at 21:45):

github-actions[bot] commented on PR #7609:

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

• [ ] If you added a new Config method, you wrote extensive documentation for
  it.

  <details>

  Our documentation should be of the following form:

  ```text
  Short, simple summary sentence.

  More details. These details can be multiple paragraphs. There should be
  information about not just the method, but its parameters and results as
  well.

  Is this method fallible? If so, when can it return an error?

  Can this method panic? If so, when does it panic?

  Example

  Optional example here.
  ```

  </details>

• [ ] If you added a new Config method, or modified an existing one, you
  ensured that this configuration is exercised by the fuzz targets.

  <details>

  For example, if you expose a new strategy for allocating the next instance
  slot inside the pooling allocator, you should ensure that at least one of our
  fuzz targets exercises that new strategy.

  Often, all that is required of you is to ensure that there is a knob for this
  configuration option in [wasmtime_fuzzing::Config][fuzzing-config] (or one
  of its nested structs).

  Rarely, this may require authoring a new fuzz target to specifically test this
  configuration. See [our docs on fuzzing][fuzzing-docs] for more details.

  </details>

• [ ] If you are enabling a configuration option by default, make sure that it
  has been fuzzed for at least two weeks before turning it on by default.

[fuzzing-config]: https://github.com/bytecodealliance/wasmtime/blob/ca0e8d0a1d8cefc0496dba2f77a670571d8fdcab/crates/fuzzing/src/generators.rs#L182-L194
[fuzzing-docs]: https://docs.wasmtime.dev/contributing-fuzzing.html

---

<details>

To modify this label's message, edit the <code>.github/label-messager/wasmtime-config.md</code> file.

To add new label messages or remove existing label messages, edit the
<code>.github/label-messager.json</code> configuration file.

Learn more.

</details>

Wasmtime GitHub notifications bot (Dec 01 2023 at 00:21):

abrown updated PR #7609.

Wasmtime GitHub notifications bot (Dec 01 2023 at 00:26):

abrown has marked PR #7609 as ready for review.

Wasmtime GitHub notifications bot (Dec 01 2023 at 00:26):

abrown requested pchickey for a review on PR #7609.

Wasmtime GitHub notifications bot (Dec 01 2023 at 00:26):

abrown requested wasmtime-core-reviewers for a review on PR #7609.

Wasmtime GitHub notifications bot (Dec 01 2023 at 00:26):

abrown requested wasmtime-default-reviewers for a review on PR #7609.

Wasmtime GitHub notifications bot (Dec 01 2023 at 18:27):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Dec 01 2023 at 21:57):

abrown updated PR #7609.

Wasmtime GitHub notifications bot (Dec 01 2023 at 21:58):

abrown has enabled auto merge for PR #7609.

Wasmtime GitHub notifications bot (Dec 01 2023 at 22:54):

abrown updated PR #7609.

Wasmtime GitHub notifications bot (Dec 01 2023 at 22:54):

abrown has enabled auto merge for PR #7609.

Wasmtime GitHub notifications bot (Dec 02 2023 at 00:30):

abrown updated PR #7609.

Wasmtime GitHub notifications bot (Dec 02 2023 at 00:30):

abrown has enabled auto merge for PR #7609.

Wasmtime GitHub notifications bot (Dec 02 2023 at 01:19):

abrown merged PR #7609.

Last updated: Nov 22 2024 at 16:03 UTC