Wasmtime GitHub notifications bot (Nov 29 2023 at 08:05): Wasmtime GitHub notifications bot (Nov 29 2023 at 08:05):scottmcm opened PR #7599 from scottmcm:simplify-arith-isle to bytecodealliance:main:
I noticed that, thanks to const prop, a few of the patterns in
arithmetic.islearen't actually needed to keep the same behaviour.This seems to have mostly lowered the register numbers in the affected tests, so it seems at least plausible. But if it's expected that patterns don't don't rely on canonicalization and it's better to keep these duplicates, then please just close this PR.
(I needed to learn how to edit patterns and write+run tests against them for what I actually want to do, so this was a useful learning exercise for me whether it lands or not.)
Wasmtime GitHub notifications bot (Nov 29 2023 at 08:05):scottmcm requested wasmtime-compiler-reviewers for a review on PR #7599.
Wasmtime GitHub notifications bot (Nov 29 2023 at 08:05):scottmcm requested elliottt for a review on PR #7599.
Wasmtime GitHub notifications bot (Nov 29 2023 at 08:50):scottmcm updated PR #7599.
Wasmtime GitHub notifications bot (Nov 29 2023 at 08:57):scottmcm updated PR #7599.
Wasmtime GitHub notifications bot (Nov 29 2023 at 10:45):github-actions[bot] commented on PR #7599:
Subscribe to Label Action
cc @cfallin, @fitzgen
<details>
This issue or pull request has been labeled: "cranelift", "isle"Thus the following users have been cc'd because of the following labels:
- cfallin: isle
- fitzgen: isle
To subscribe or unsubscribe from this label, edit the <code>.github/subscribe-to-label.json</code> configuration file.
Learn more.
</details>
Wasmtime GitHub notifications bot (Nov 29 2023 at 16:26):alexcrichton submitted PR review:
No worries about the renumbering, that is indeed expected. Thanks for the PR!
Wasmtime GitHub notifications bot (Nov 29 2023 at 17:03):alexcrichton merged PR #7599.
Last updated: Nov 22 2024 at 16:03 UTC