Stream: git-wasmtime

Topic: wasmtime / PR #7598 move wasi's Table to wasmtime::compon...

Wasmtime GitHub notifications bot (Nov 29 2023 at 00:05):

pchickey opened PR #7598 from bytecodealliance:pch/resource_table to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 29 2023 at 00:05):

pchickey edited PR #7598:

I hated the WasiView trait from the minute I first wrote it, so we're gonna put that table into Store.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 29 2023 at 01:29):

pchickey updated PR #7598.

Wasmtime GitHub notifications bot (Nov 30 2023 at 20:53):

pchickey closed without merge PR #7598.

Wasmtime GitHub notifications bot (Nov 30 2023 at 20:53):

pchickey commented on PR #7598:

Alex and I just talked through my approach here and found a different tactic that will get most of the benefits with a lot less changing of every single dang method to take an extra table argument, so I'll redo this in a fresh branch.

Last updated: Nov 22 2024 at 16:03 UTC