Stream: git-wasmtime

Topic: wasmtime / PR #7597 Trim `wasmtime serve`'s default world

Wasmtime GitHub notifications bot (Nov 28 2023 at 21:46):

alexcrichton opened PR #7597 from alexcrichton:slim-proxy to bytecodealliance:main:

This commit aims to address a discrepancy in Wasmtime where the world supported by wasmtime serve is too large today. This includes WIT interfaces which are not specified in wasi:http/proxy such as wasi:filesystem/types, aka access to a filesystem.

This commit slims down wasmtime serve to, by default, only supporting the wasi:http/proxy world. Like with wasmtime run various CLI flags can be passed to enable more interfaces, however:

• -Scommon - this enables "common" interfaces such as wasi:filesystem, wasi:sockets, and wasi:cli/*.
• -Snn - this enables wasi-nn

It's expected that more will get extended here over time too.

This change is enabled by a third build of the adapter, a "proxy" mode. In this mode most functions are cfg'd to return ERRNO_NOTSUP to indicate that the runtime does not support it. Notably this includes the filesystem, arguments, and environment variables.

This change is tested by updating all api_proxy* tests to use this new adapter which is now required that many previous interfaces are no longer present by default in the proxy world.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 28 2023 at 21:46):

alexcrichton requested pchickey for a review on PR #7597.

Wasmtime GitHub notifications bot (Nov 28 2023 at 21:46):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7597.

Wasmtime GitHub notifications bot (Nov 28 2023 at 21:46):

alexcrichton requested wasmtime-default-reviewers for a review on PR #7597.

Wasmtime GitHub notifications bot (Nov 29 2023 at 19:26):

elliottt submitted PR review:

This looks great!

Wasmtime GitHub notifications bot (Nov 29 2023 at 19:26):

elliottt submitted PR review:

This looks great!

Wasmtime GitHub notifications bot (Nov 29 2023 at 19:26):

elliottt created PR review comment:

:tada:

Wasmtime GitHub notifications bot (Nov 29 2023 at 20:08):

alexcrichton merged PR #7597.

Last updated: Nov 22 2024 at 17:03 UTC