alexcrichton opened PR #7597 from alexcrichton:slim-proxy
to bytecodealliance:main
:
This commit aims to address a discrepancy in Wasmtime where the world supported by
wasmtime serve
is too large today. This includes WIT interfaces which are not specified inwasi:http/proxy
such aswasi:filesystem/types
, aka access to a filesystem.This commit slims down
wasmtime serve
to, by default, only supporting thewasi:http/proxy
world. Like withwasmtime run
various CLI flags can be passed to enable more interfaces, however:
-Scommon
- this enables "common" interfaces such aswasi:filesystem
,wasi:sockets
, andwasi:cli/*
.-Snn
- this enables wasi-nnIt's expected that more will get extended here over time too.
This change is enabled by a third build of the adapter, a "proxy" mode. In this mode most functions are cfg'd to return
ERRNO_NOTSUP
to indicate that the runtime does not support it. Notably this includes the filesystem, arguments, and environment variables.This change is tested by updating all
api_proxy*
tests to use this new adapter which is now required that many previous interfaces are no longer present by default in the proxy world.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested pchickey for a review on PR #7597.
alexcrichton requested wasmtime-core-reviewers for a review on PR #7597.
alexcrichton requested wasmtime-default-reviewers for a review on PR #7597.
elliottt submitted PR review:
This looks great!
elliottt submitted PR review:
This looks great!
elliottt created PR review comment:
:tada:
alexcrichton merged PR #7597.
Last updated: Dec 23 2024 at 12:05 UTC