Stream: git-wasmtime

Topic: wasmtime / PR #7589 wasi-http spec tweaks

Wasmtime GitHub notifications bot (Nov 27 2023 at 22:33):

elliottt opened PR #7589 from elliottt:trevor/http-changes to bytecodealliance:main:

This is a draft of some proposed tweaks to the wasi-http spec:

• Removing the -ms suffix on the timout setters, and references to the value being in milliseconds

• Making the future-trailers.get method return the trailers only once, and as a result also returning an owned HostFields
  <!--
  Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 28 2023 at 15:11):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 28 2023 at 15:11):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 28 2023 at 15:11):

alexcrichton created PR review comment:

Question on this: why not combine the "you already called this" error into error-code? That wouldn't require two layers of result since the signature is pretty gnarly here.

I realize though that other futures-related things are doing two layers of results is one reason for this. That's probably enough for now I suppose.

Wasmtime GitHub notifications bot (Nov 28 2023 at 15:11):

alexcrichton created PR review comment:

I think the internals of all these methods also need to change since right now they're using *_millis-related Duration methods

Wasmtime GitHub notifications bot (Nov 28 2023 at 15:58):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Nov 28 2023 at 15:58):

pchickey created PR review comment:

Yes, we are sticking to the same convention for the sake of bindings generators knowing how to translate the "futures pattern" into some native future. its not a fully baked thing yet but we at least want to try.

Wasmtime GitHub notifications bot (Nov 28 2023 at 16:32):

elliottt updated PR #7589.

Wasmtime GitHub notifications bot (Nov 28 2023 at 16:33):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 28 2023 at 16:33):

elliottt created PR review comment:

Good catch, thanks!

Wasmtime GitHub notifications bot (Nov 29 2023 at 18:08):

elliottt has marked PR #7589 as ready for review.

Wasmtime GitHub notifications bot (Nov 29 2023 at 18:08):

elliottt requested wasmtime-core-reviewers for a review on PR #7589.

Wasmtime GitHub notifications bot (Nov 29 2023 at 18:08):

elliottt requested alexcrichton for a review on PR #7589.

Wasmtime GitHub notifications bot (Nov 29 2023 at 18:27):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Nov 29 2023 at 18:59):

pchickey merged PR #7589.

Last updated: Dec 23 2024 at 12:05 UTC