Wasmtime GitHub notifications bot (Nov 27 2023 at 16:52): Wasmtime GitHub notifications bot (Nov 27 2023 at 16:52):alexcrichton requested pchickey for a review on PR #7586.
Wasmtime GitHub notifications bot (Nov 27 2023 at 16:52):alexcrichton requested wasmtime-core-reviewers for a review on PR #7586.
Wasmtime GitHub notifications bot (Nov 27 2023 at 16:52):alexcrichton opened PR #7586 from alexcrichton:update-preview1-seek-on-appending-files to bytecodealliance:main:
This commit updates the semantics of
fd_{seek,tell}on preview1 to match native Unix when used with appending files. On Unixwriteclaims to always update the file position pointer to the end of the file, so this commit implements that instead of the previous logic of ignoring the position update for appending files. This currently requires an extra roundtrip viastatto figure out the size of the file, but for now that seems to be the best that can be done.Closes #7583
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 27 2023 at 17:13):pchickey submitted PR review:
Thanks!
Wasmtime GitHub notifications bot (Nov 27 2023 at 17:49):pchickey merged PR #7586.
Last updated: Oct 23 2024 at 20:03 UTC