Mrmaxmeier opened PR #7584 from Mrmaxmeier:aarch64-got-relocs
to bytecodealliance:main
:
This is a prerequisite for #2735, but doesn't implement the PLT entries yet.
(I'm using hot function replace, which happens in the GOT but doesn't strictly require the PLT.)The instruction encoding for
adrp
is kind of complicated, but re-using existing lowering infrastructure doesn't work well since it's not designed to do partial updates. Xref: #5550, which introduced these relocation types.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Mrmaxmeier requested elliottt for a review on PR #7584.
Mrmaxmeier requested wasmtime-compiler-reviewers for a review on PR #7584.
elliottt submitted PR review:
Happy to approve after the offsets are removed, thank you!
elliottt submitted PR review:
Happy to approve after the offsets are removed, thank you!
elliottt created PR review comment:
We only emit
Aarch64AdrGotPage21
relocations with anaddend
of0
. Would you mind removing the offset, and instead asserting that it's0
?Additionally, to fully implement the operation
Page(G(GDAT(S+A)))-Page(P)
we would need to modify the functionget_got_entry
that's passed in, as we would need to make the offset calculation before looking up in the GOT. Asserting that theaddend
is zero means that we can avoid that refactoring.
elliottt created PR review comment:
We only emit
Aarch64Ld64GotLo12Nc
relocations with anaddend
of0
. Would you mind removing the offset, and instead asserting that it's0
?
Mrmaxmeier updated PR #7584.
Mrmaxmeier updated PR #7584.
Mrmaxmeier submitted PR review.
Mrmaxmeier created PR review comment:
Good catch! :+1:
elliottt submitted PR review:
Thank you!
elliottt merged PR #7584.
Last updated: Dec 23 2024 at 13:07 UTC