Stream: git-wasmtime

Topic: wasmtime / PR #7576 mpk: allow forcing MPK during tests

Wasmtime GitHub notifications bot (Nov 22 2023 at 22:09):

abrown requested alexcrichton for a review on PR #7576.

Wasmtime GitHub notifications bot (Nov 22 2023 at 22:09):

abrown opened PR #7576 from abrown:pku-force-test to bytecodealliance:main:

For testing on machines on which we know MPK is enabled, we want to be
able to force-enable MPK, ensuring we get coverage of MPK-related code.
This change adds a WASMTIME_TEST_FORCE_MPK environment variable which,
when set, sets the pooling allocator configuration to force-enable MPK.
This variable, like the WASMTIME_TEST_NO_HOG_MEMORY variable it is
styled from, could be used in CI workflows on which we know MPK should
be available.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 22 2023 at 22:09):

abrown requested wasmtime-core-reviewers for a review on PR #7576.

Wasmtime GitHub notifications bot (Nov 27 2023 at 23:21):

abrown updated PR #7576.

Wasmtime GitHub notifications bot (Nov 28 2023 at 15:03):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 28 2023 at 15:34):

alexcrichton merged PR #7576.

Last updated: Nov 22 2024 at 16:03 UTC