Wasmtime GitHub notifications bot (Nov 22 2023 at 22:04): Wasmtime GitHub notifications bot (Nov 22 2023 at 22:04):abrown opened PR #7575 from abrown:pku-wrong-bit to bytecodealliance:main:
This bug was discovered when testing with QEMU: the documentation states
that "bit 3" should be checked but this is a 0-based bit. The check
previously performed a 1-based "bit 3" check, which tests the UMIP
feature. This change switches to use the correct bit.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 22 2023 at 22:04):abrown requested wasmtime-core-reviewers for a review on PR #7575.
Wasmtime GitHub notifications bot (Nov 22 2023 at 22:04):abrown requested pchickey for a review on PR #7575.
Wasmtime GitHub notifications bot (Nov 22 2023 at 22:06):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Nov 22 2023 at 22:06):alexcrichton has enabled auto merge for PR #7575.
Wasmtime GitHub notifications bot (Nov 22 2023 at 22:55):alexcrichton merged PR #7575.
Last updated: Nov 22 2024 at 17:03 UTC