Stream: git-wasmtime

Topic: wasmtime / PR #7569 wasi: accurate timing option, when di...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 21 2023 at 21:49):

guybedford edited PR #7569.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 21 2023 at 21:49):

guybedford edited PR #7569:

Node.js mtime setting only works up to 100µs accuracy.

This updates the test to work at this level at minimum when the NO_ACCURATE_TIME option is set.

We could make this a configurable test option, I just wasn't sure how to set up such a conditional build feature for the test program - suggestions welcome if not reducing overall accuracy is preferred.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2023 at 00:36):

guybedford updated PR #7569.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2023 at 00:37):

guybedford updated PR #7569.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2023 at 00:59):

guybedford updated PR #7569.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2023 at 18:45):

guybedford edited PR #7569:

Node.js mtime setting only works up to 100µs accuracy.

This updates the test to work at this level at minimum when the NO_ACCURATE_TIME option is set.

We could make this a configurable test option, I just wasn't sure how to set up such a conditional build feature for the test program - suggestions welcome if not reducing overall accuracy is preferred.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2023 at 18:45):

guybedford edited PR #7569:

Node.js mtime setting only works up to microsecond accuracy.

This updates the test to work at this level at minimum when the NO_ACCURATE_TIME option is set.

We could make this a configurable test option, I just wasn't sure how to set up such a conditional build feature for the test program - suggestions welcome if not reducing overall accuracy is preferred.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2023 at 18:46):

guybedford submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2023 at 18:46):

guybedford created PR review comment:

Ahh I misread the documentation here that the units were 100 nanoseconds.

The actual units are therefore microsecond accuracy and this is 2 microseconds.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2023 at 20:17):

guybedford updated PR #7569.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 22 2023 at 20:23):

guybedford edited PR #7569:

Node.js mtime setting only works up to microsecond accuracy.

This updates the test to work at this level at minimum when the FS_TIME_PRECISION option is set.

We could make this a configurable test option, I just wasn't sure how to set up such a conditional build feature for the test program - suggestions welcome if not reducing overall accuracy is preferred.

Last updated: Nov 22 2024 at 16:03 UTC