pchickey opened PR #7564 from bytecodealliance:pch/separate_process_stdin
to bytecodealliance:main
:
fork is always a terrible idea, but when we wrote this test, we couldn't think of an alternative method. alex showed us how
/tests/host_segfault.rs
works, which solves a similar problem for measuring process behavior without forking.the forking version of this test would occasionally hang in the child's creation of a tokio runtime because std Once is not fork-safe (nor should it be. nothing should be fork-safe. forks are an abomination).
so instead, this is now a separate integration test with
harness = false
that will exec itself in order to run the child.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
pchickey requested wasmtime-core-reviewers for a review on PR #7564.
pchickey requested alexcrichton for a review on PR #7564.
alexcrichton submitted PR review.
alexcrichton has enabled auto merge for PR #7564.
pchickey updated PR #7564.
pchickey updated PR #7564.
pchickey has enabled auto merge for PR #7564.
pchickey merged PR #7564.
Last updated: Dec 23 2024 at 12:05 UTC