Stream: git-wasmtime

Topic: wasmtime / PR #7564 move wasmtime-wasi's unit test for st...

Wasmtime GitHub notifications bot (Nov 21 2023 at 01:54):

pchickey opened PR #7564 from bytecodealliance:pch/separate_process_stdin to bytecodealliance:main:

fork is always a terrible idea, but when we wrote this test, we couldn't think of an alternative method. alex showed us how /tests/host_segfault.rs works, which solves a similar problem for measuring process behavior without forking.

the forking version of this test would occasionally hang in the child's creation of a tokio runtime because std Once is not fork-safe (nor should it be. nothing should be fork-safe. forks are an abomination).

so instead, this is now a separate integration test with harness = false that will exec itself in order to run the child.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 21 2023 at 01:54):

pchickey requested wasmtime-core-reviewers for a review on PR #7564.

Wasmtime GitHub notifications bot (Nov 21 2023 at 01:54):

pchickey requested alexcrichton for a review on PR #7564.

Wasmtime GitHub notifications bot (Nov 21 2023 at 02:05):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 21 2023 at 02:05):

alexcrichton has enabled auto merge for PR #7564.

Wasmtime GitHub notifications bot (Nov 21 2023 at 05:25):

pchickey updated PR #7564.

Wasmtime GitHub notifications bot (Nov 21 2023 at 17:20):

pchickey updated PR #7564.

Wasmtime GitHub notifications bot (Nov 21 2023 at 17:20):

pchickey has enabled auto merge for PR #7564.

Wasmtime GitHub notifications bot (Nov 21 2023 at 18:14):

pchickey merged PR #7564.

Last updated: Nov 22 2024 at 16:03 UTC