Stream: git-wasmtime

Topic: wasmtime / PR #7553 Wasi test suite cleanups

Wasmtime GitHub notifications bot (Nov 16 2023 at 19:37):

pchickey opened PR #7553 from bytecodealliance:pch/wasi_test_cleanups to bytecodealliance:main:

We have had three wasi preview1 tests that have been marked should_panic since they were written years ago, because some part of the behavior they tested isn't consistent across operating systems. This PR changes those tests to only test consistent behavior, notes what behavior is not tested, and enforces that they pass from here out:

• remove_directory_trailing_slashes is now renamed remove_directory

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 16 2023 at 19:37):

pchickey requested alexcrichton for a review on PR #7553.

Wasmtime GitHub notifications bot (Nov 16 2023 at 19:37):

pchickey requested wasmtime-core-reviewers for a review on PR #7553.

Wasmtime GitHub notifications bot (Nov 16 2023 at 19:43):

pchickey updated PR #7553.

Wasmtime GitHub notifications bot (Nov 16 2023 at 19:44):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 16 2023 at 19:47):

pchickey updated PR #7553.

Wasmtime GitHub notifications bot (Nov 16 2023 at 19:48):

pchickey edited PR #7553:

We have had three wasi preview1 tests that have been marked should_panic since they were written years ago, because some part of the behavior they tested isn't consistent across operating systems. This PR changes those tests to only test consistent behavior, notes what behavior is not tested, and enforces that they pass from here out:

• preview1_remove_directory_trailing_slashes is now renamed preview1_remove_directory, and no longer tests for the trailing slash behavior that is inconsistient.
• preview1_path_rename_trailing_slashes is deleted. the consistient behavior is covered by the preview1_path_rename and preview1_path_rename_dir_trailing_slashes tests.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 16 2023 at 20:06):

pchickey updated PR #7553.

Wasmtime GitHub notifications bot (Nov 16 2023 at 20:38):

pchickey updated PR #7553.

Wasmtime GitHub notifications bot (Nov 16 2023 at 20:56):

pchickey updated PR #7553.

Wasmtime GitHub notifications bot (Nov 17 2023 at 00:31):

pchickey edited PR #7553:

We have had three wasi preview1 tests that have been marked should_panic since they were written years ago, because some part of the behavior they tested isn't consistent across operating systems. This PR changes those tests to only test consistent behavior, notes what behavior is not tested, and enforces that they pass from here out:

• preview1_remove_directory_trailing_slashes is now renamed preview1_remove_directory, and no longer tests for the trailing slash behavior that is inconsistient. I also fixed an incorrect assertion about windows behavior which the other test prevented from being executed.
• preview1_path_rename_trailing_slashes is deleted. the consistient behavior is covered by the preview1_path_rename and preview1_path_rename_dir_trailing_slashes tests.
• preview1_interesting_paths now describes the windows behavior correctly- a trailing nul byte is accepted on windows, apparently.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 17 2023 at 01:05):

pchickey merged PR #7553.

Last updated: Nov 22 2024 at 16:03 UTC