Stream: git-wasmtime

Topic: wasmtime / PR #7545 wasi-http: Populate the authority and...

Wasmtime GitHub notifications bot (Nov 15 2023 at 19:12):

elliottt opened PR #7545 from elliottt:trevor/serve-host to bytecodealliance:main:

Ensure that the scheme and authority are populated in the requests given to the incoming handler with wasmtime serve. We prefer the Host header if it's available, falling back on the existing value of the authority in the request. Additionally, we fall back on http as the scheme when none was present.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 15 2023 at 19:12):

elliottt requested alexcrichton for a review on PR #7545.

Wasmtime GitHub notifications bot (Nov 15 2023 at 19:12):

elliottt requested wasmtime-core-reviewers for a review on PR #7545.

Wasmtime GitHub notifications bot (Nov 15 2023 at 19:12):

elliottt requested wasmtime-default-reviewers for a review on PR #7545.

Wasmtime GitHub notifications bot (Nov 15 2023 at 19:13):

elliottt edited PR #7545:

Ensure that the scheme and authority are populated in the requests given to the incoming handler with wasmtime serve. We prefer the Host header if it's available, falling back on the existing value of the authority in the request. Additionally, we fall back on http as the scheme when none was present. This behavior mirrors what https://github.com/fastly/vicroy does for request handling, and ensures that runtimes that require an incoming authority to be set (like the javascript runtime) have one available.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 15 2023 at 19:13):

elliottt edited PR #7545:

Ensure that the scheme and authority are populated in the requests given to the incoming handler with wasmtime serve. We prefer the Host header if it's available, falling back on the existing value of the authority in the request. Additionally, we fall back on http as the scheme when none was present. This behavior mirrors what https://github.com/fastly/vicroy does for request handling, and ensures that runtimes that require an incoming authority to be set (like the javascript runtime) have one available.

cc @tschneidereit @JakeChampion
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 15 2023 at 19:13):

elliottt requested pchickey for a review on PR #7545.

Wasmtime GitHub notifications bot (Nov 15 2023 at 19:20):

guybedford submitted PR review.

Wasmtime GitHub notifications bot (Nov 15 2023 at 19:20):

guybedford created PR review comment:

Why not default to HTTPS? Is this also to align with Viceroy?

Wasmtime GitHub notifications bot (Nov 15 2023 at 19:24):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 15 2023 at 19:24):

elliottt created PR review comment:

wasmtime serve doesn't currently support listening on https, but if that changes in the future we could make it default to what the server's listening on.

Wasmtime GitHub notifications bot (Nov 15 2023 at 19:55):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Nov 15 2023 at 20:30):

elliottt merged PR #7545.

Last updated: Nov 22 2024 at 17:03 UTC