Stream: git-wasmtime

Topic: wasmtime / PR #7527 wasi-http: Validate Content-Length wh...

Wasmtime GitHub notifications bot (Nov 10 2023 at 22:36):

elliottt opened PR #7527 from elliottt:trevor/validate-content-length to bytecodealliance:main:

Make use of immutable header state to track how much has been written to an output-body stream, ensuring that we write exactly as much as was mentioned in the Content-Length header.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 10 2023 at 22:36):

elliottt requested pchickey for a review on PR #7527.

Wasmtime GitHub notifications bot (Nov 10 2023 at 22:36):

elliottt requested wasmtime-core-reviewers for a review on PR #7527.

Wasmtime GitHub notifications bot (Nov 10 2023 at 22:37):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Nov 10 2023 at 23:08):

elliottt updated PR #7527.

Wasmtime GitHub notifications bot (Nov 11 2023 at 20:23):

elliottt updated PR #7527.

Wasmtime GitHub notifications bot (Nov 12 2023 at 05:07):

elliottt updated PR #7527.

Wasmtime GitHub notifications bot (Nov 13 2023 at 16:23):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 13 2023 at 16:23):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 13 2023 at 16:23):

alexcrichton created PR review comment:

Could this take usize instead of u64 to move the cast into here instead of handling that at all callers?

Wasmtime GitHub notifications bot (Nov 13 2023 at 16:23):

alexcrichton created PR review comment:

Also could this method have documentation as to its return value? (plus the one below)

Wasmtime GitHub notifications bot (Nov 13 2023 at 16:23):

alexcrichton created PR review comment:

Could this use matching to avoid the unwrap()?

Wasmtime GitHub notifications bot (Nov 13 2023 at 16:23):

alexcrichton created PR review comment:

I'm not 100% sure as to the context of this comment but sending on a oneshot does not guarantee the message is received, it's only queued up at that time to possible be received in the future.

Wasmtime GitHub notifications bot (Nov 13 2023 at 18:48):

elliottt updated PR #7527.

Wasmtime GitHub notifications bot (Nov 13 2023 at 19:10):

elliottt submitted PR review.

Wasmtime GitHub notifications bot (Nov 13 2023 at 19:10):

elliottt created PR review comment:

I was wondering if we would potentially block on the oneshot send if there was nothing already waiting to receive it. It sounds like that's not the case, so I'll remove the TODO. Thanks!

Wasmtime GitHub notifications bot (Nov 13 2023 at 19:11):

elliottt updated PR #7527.

Wasmtime GitHub notifications bot (Nov 13 2023 at 22:41):

elliottt merged PR #7527.

Last updated: Dec 23 2024 at 12:05 UTC