Stream: git-wasmtime

Topic: wasmtime / PR #7523 cranelift-entity: Add `get_many_mut` ...

Wasmtime GitHub notifications bot (Nov 10 2023 at 16:02):

simvux opened PR #7523 from simvux:cl_entity_add_get_many_mut to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

PrimaryMap does not expose an as_slice_mut method since that bypasses the need for the key. However; this also prevents you from being able to access multiple indices at once safely via slice::split_mut() or the unstable slice::get_many_mut.

This PR adds a version of get_many_mut which takes [K; N] instead of slice's [usize; N]

Wasmtime GitHub notifications bot (Nov 10 2023 at 16:02):

simvux requested abrown for a review on PR #7523.

Wasmtime GitHub notifications bot (Nov 10 2023 at 16:02):

simvux requested wasmtime-compiler-reviewers for a review on PR #7523.

Wasmtime GitHub notifications bot (Nov 10 2023 at 21:19):

fitzgen submitted PR review:

LGTM, thanks!

Wasmtime GitHub notifications bot (Nov 10 2023 at 22:06):

fitzgen merged PR #7523.

Last updated: Dec 23 2024 at 12:05 UTC