Stream: git-wasmtime

Topic: wasmtime / PR #7522 riscv64: use `vadd.vi` for small imme...

Wasmtime GitHub notifications bot (Nov 10 2023 at 03:01):

pyroMechanical requested elliottt for a review on PR #7522.

Wasmtime GitHub notifications bot (Nov 10 2023 at 03:01):

pyroMechanical opened PR #7522 from pyroMechanical:main to bytecodealliance:main:

this PR implements the change requested in #7481. Since riscv64 doesn't have a vsub.vi instruction, this optimization removes a load when the immediate fits in an Imm5.

Wasmtime GitHub notifications bot (Nov 10 2023 at 03:01):

pyroMechanical requested wasmtime-compiler-reviewers for a review on PR #7522.

Wasmtime GitHub notifications bot (Nov 10 2023 at 07:54):

elliottt submitted PR review:

This looks good to me! @afonso360, would you mind taking a look as well?

Wasmtime GitHub notifications bot (Nov 10 2023 at 07:54):

elliottt submitted PR review:

This looks good to me! @afonso360, would you mind taking a look as well?

Wasmtime GitHub notifications bot (Nov 10 2023 at 07:54):

elliottt created PR review comment:

;; Like imm5_from_value, but first negates the `Value`.
(decl pure partial imm5_from_negated_value (Value) Imm5)
(rule (imm5_from_negated_value (has_type ty (iconst n)))
  (if-let (imm5_from_i64 imm) (i64_neg (i64_sextend_imm64 ty n)))
  imm)

Wasmtime GitHub notifications bot (Nov 10 2023 at 11:43):

afonso360 submitted PR review:

This looks great! Thanks! :tada:

Wasmtime GitHub notifications bot (Nov 23 2023 at 14:07):

afonso360 updated PR #7522.

Wasmtime GitHub notifications bot (Nov 23 2023 at 14:07):

afonso360 has enabled auto merge for PR #7522.

Wasmtime GitHub notifications bot (Nov 23 2023 at 14:58):

afonso360 merged PR #7522.

Last updated: Nov 22 2024 at 16:03 UTC