pyroMechanical requested elliottt for a review on PR #7522.
pyroMechanical opened PR #7522 from pyroMechanical:main
to bytecodealliance:main
:
this PR implements the change requested in #7481. Since riscv64 doesn't have a
vsub.vi
instruction, this optimization removes a load when the immediate fits in an Imm5.
pyroMechanical requested wasmtime-compiler-reviewers for a review on PR #7522.
elliottt submitted PR review:
This looks good to me! @afonso360, would you mind taking a look as well?
elliottt submitted PR review:
This looks good to me! @afonso360, would you mind taking a look as well?
elliottt created PR review comment:
;; Like imm5_from_value, but first negates the `Value`. (decl pure partial imm5_from_negated_value (Value) Imm5) (rule (imm5_from_negated_value (has_type ty (iconst n))) (if-let (imm5_from_i64 imm) (i64_neg (i64_sextend_imm64 ty n))) imm)
afonso360 submitted PR review:
This looks great! Thanks! :tada:
afonso360 updated PR #7522.
afonso360 has enabled auto merge for PR #7522.
afonso360 merged PR #7522.
Last updated: Dec 23 2024 at 12:05 UTC