Stream: git-wasmtime

Topic: wasmtime / PR #7509 Run custom signal handler tests on macOS

Wasmtime GitHub notifications bot (Nov 08 2023 at 22:21):

alexcrichton opened PR #7509 from alexcrichton:macos-posix-signals-test to bytecodealliance:main:

This commit fixes a mistake where these tests were not being run on macOS after signal handling was moved behind a Config flag instead of being a crate feature. Additionally these tests are moved to their own test file to ensure that each process either uses Mach Ports or signals (this one uses signals which is non-default).

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 08 2023 at 22:21):

alexcrichton requested fitzgen for a review on PR #7509.

Wasmtime GitHub notifications bot (Nov 08 2023 at 22:21):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7509.

Wasmtime GitHub notifications bot (Nov 08 2023 at 22:22):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Nov 08 2023 at 22:22):

fitzgen has enabled auto merge for PR #7509.

Wasmtime GitHub notifications bot (Nov 08 2023 at 23:22):

fitzgen merged PR #7509.

Last updated: Nov 22 2024 at 16:03 UTC