Stream: git-wasmtime

Topic: wasmtime / PR #7503 ISLE: Allow callers to pass in storag...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 08 2023 at 19:53):

fitzgen opened PR #7503 from fitzgen:reuse-storage to bytecodealliance:main:

This allows callers to reuse storage and avoid allocations.

Internal constructors calling internal constructors won't reuse storage (at
least for now) but it is an option for the user code that is calling into ISLE.

Part of #7500

view this post on Zulip Wasmtime GitHub notifications bot (Nov 08 2023 at 19:53):

fitzgen requested wasmtime-compiler-reviewers for a review on PR #7503.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 08 2023 at 19:53):

fitzgen requested abrown for a review on PR #7503.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 09 2023 at 17:43):

fitzgen requested elliottt for a review on PR #7503.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 10 2023 at 07:41):

elliottt submitted PR review:

Nice!

view this post on Zulip Wasmtime GitHub notifications bot (Nov 10 2023 at 07:41):

elliottt submitted PR review:

Nice!

view this post on Zulip Wasmtime GitHub notifications bot (Nov 10 2023 at 07:41):

elliottt created PR review comment:

Is the choice of Option for the iterator here significant, or would std::iter::once also work?

view this post on Zulip Wasmtime GitHub notifications bot (Nov 10 2023 at 19:44):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 10 2023 at 19:44):

fitzgen created PR review comment:

std::iter::once would also work, no strong feelings either way.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 10 2023 at 20:35):

fitzgen merged PR #7503.

Last updated: Dec 23 2024 at 12:05 UTC