Wasmtime GitHub notifications bot (Nov 08 2023 at 15:57): Wasmtime GitHub notifications bot (Nov 08 2023 at 15:57):saulecabrera requested fitzgen for a review on PR #7501.
Wasmtime GitHub notifications bot (Nov 08 2023 at 15:57):saulecabrera requested wasmtime-compiler-reviewers for a review on PR #7501.
Wasmtime GitHub notifications bot (Nov 08 2023 at 15:57):saulecabrera requested wasmtime-core-reviewers for a review on PR #7501.
Wasmtime GitHub notifications bot (Nov 08 2023 at 15:57):saulecabrera opened PR #7501 from saulecabrera:properly-derive-scratch-for-calls to bytecodealliance:main:
This commit properly derives a scratch register for a particular WebAssembly type. The included spec test uncovered that the previous implementation used a int scratch register to assign float stack arguments, which resulted in a panic.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 08 2023 at 16:58):fitzgen submitted PR review:
Nice!
Wasmtime GitHub notifications bot (Nov 08 2023 at 17:40):fitzgen merged PR #7501.
Last updated: Dec 23 2024 at 12:05 UTC