Stream: git-wasmtime

Topic: wasmtime / PR #7491 riscv64: Rollback `isub` const LHS op...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 07 2023 at 10:38):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #7491.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 07 2023 at 10:38):

afonso360 opened PR #7491 from afonso360:riscv-isub-fix to bytecodealliance:main:

:wave: Hey,

This PR fixes a bug with #7480. Where we used addi instead of isub when either the LHS or RHS are constant. This is correct for the RHS rule, but not for LHS since the subtraction isn't commutative.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 07 2023 at 10:38):

afonso360 requested elliottt for a review on PR #7491.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 07 2023 at 14:14):

alexcrichton submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 07 2023 at 15:01):

alexcrichton merged PR #7491.

Last updated: Dec 23 2024 at 12:05 UTC