elliottt opened PR #7490 from elliottt:trevor/forbidden-delete
to bytecodealliance:main
:
Disallow
fields.delete
on forbidden headers. This isn't a spec change, just a wasmtime behavioral change, though we may want to consider modifying the result value ofdelete
to beresult
, as @JakeChampion pointed out that it's similar to aset
in principle.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
elliottt requested alexcrichton for a review on PR #7490.
elliottt requested wasmtime-core-reviewers for a review on PR #7490.
elliottt requested pchickey for a review on PR #7490.
elliottt edited PR #7490:
Disallow
fields.delete
on forbidden headers. This isn't a spec change, just a wasmtime behavioral change, though we may want to consider modifying the result value ofdelete
to beresult
, as @JakeChampion pointed out that it's similar to aset
in principle.The included changes to the api_proxy.rs module and
wasi_http_proxy_tests
test fail on main currently.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
elliottt updated PR #7490.
elliottt edited PR #7490:
Disallow
fields.delete
on forbidden headers. This isn't a spec change, just a wasmtime behavioral change. We may want to consider modifying the result value ofdelete
to beresult
, as @JakeChampion pointed out that it's similar to aset
in principle.The included changes to the api_proxy.rs module and
wasi_http_proxy_tests
test fail on main currently.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
elliottt updated PR #7490.
pchickey submitted PR review.
elliottt edited PR #7490:
Disallow
fields.delete
on forbidden headers, and modifies its signature to return a result.The included changes to the api_proxy.rs module and
wasi_http_proxy_tests
test fail on main currently.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
elliottt edited PR #7490:
Disallow
fields.delete
on forbidden headers, and modifies its signature to return a result. As @JakeChampion pointed out,delete
is sort of a special form ofset
, so we should return a similar result.The included changes to the api_proxy.rs module and
wasi_http_proxy_tests
test fail on main currently.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
elliottt updated PR #7490.
elliottt merged PR #7490.
Last updated: Dec 23 2024 at 13:07 UTC