Wasmtime GitHub notifications bot (Nov 06 2023 at 19:56): Wasmtime GitHub notifications bot (Nov 06 2023 at 19:56):elliottt opened PR #7490 from elliottt:trevor/forbidden-delete to bytecodealliance:main:
Disallow
fields.deleteon forbidden headers. This isn't a spec change, just a wasmtime behavioral change, though we may want to consider modifying the result value ofdeleteto beresult, as @JakeChampion pointed out that it's similar to asetin principle.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 06 2023 at 19:56):elliottt requested alexcrichton for a review on PR #7490.
Wasmtime GitHub notifications bot (Nov 06 2023 at 19:56):elliottt requested wasmtime-core-reviewers for a review on PR #7490.
Wasmtime GitHub notifications bot (Nov 06 2023 at 19:56):elliottt requested pchickey for a review on PR #7490.
Wasmtime GitHub notifications bot (Nov 06 2023 at 19:57):elliottt edited PR #7490:
Disallow
fields.deleteon forbidden headers. This isn't a spec change, just a wasmtime behavioral change, though we may want to consider modifying the result value ofdeleteto beresult, as @JakeChampion pointed out that it's similar to asetin principle.The included changes to the api_proxy.rs module and
wasi_http_proxy_teststest fail on main currently.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 06 2023 at 19:58):elliottt updated PR #7490.
Wasmtime GitHub notifications bot (Nov 06 2023 at 22:07):elliottt edited PR #7490:
Disallow
fields.deleteon forbidden headers. This isn't a spec change, just a wasmtime behavioral change. We may want to consider modifying the result value ofdeleteto beresult, as @JakeChampion pointed out that it's similar to asetin principle.The included changes to the api_proxy.rs module and
wasi_http_proxy_teststest fail on main currently.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 06 2023 at 22:27):elliottt updated PR #7490.
Wasmtime GitHub notifications bot (Nov 06 2023 at 22:27):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Nov 06 2023 at 22:28):elliottt edited PR #7490:
Disallow
fields.deleteon forbidden headers, and modifies its signature to return a result.The included changes to the api_proxy.rs module and
wasi_http_proxy_teststest fail on main currently.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 06 2023 at 22:29):elliottt edited PR #7490:
Disallow
fields.deleteon forbidden headers, and modifies its signature to return a result. As @JakeChampion pointed out,deleteis sort of a special form ofset, so we should return a similar result.The included changes to the api_proxy.rs module and
wasi_http_proxy_teststest fail on main currently.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 07 2023 at 21:06):elliottt updated PR #7490.
Wasmtime GitHub notifications bot (Nov 07 2023 at 22:13):elliottt merged PR #7490.
Last updated: Nov 22 2024 at 16:03 UTC