Wasmtime GitHub notifications bot (Nov 05 2023 at 12:51): Wasmtime GitHub notifications bot (Nov 05 2023 at 12:51):badeend opened PR #7483 from badeend:simplify-ip-name-lookup to bytecodealliance:main:
Simplify ip name lookup interface:
- Remove the non-essential parameters for now. Post-preview2 these can be reevaluated again.
- Lift the restriction against parsing IP addresses. Before, implementations still needed to parse IP addresses to decide whether or not to return an error.
Related: https://github.com/bytecodealliance/wasmtime/issues/7013
FYI, the test includes a lookup to
münchen.deto test for internationalized domain names support. But it might be a bit weird to query this random, non-affiliated DNS server in the wasmtime CI. I tried looking for a standard testdomain (like example.com), but couldn't find any.
Wasmtime GitHub notifications bot (Nov 05 2023 at 12:51):badeend requested wasmtime-core-reviewers for a review on PR #7483.
Wasmtime GitHub notifications bot (Nov 05 2023 at 12:51):badeend requested fitzgen for a review on PR #7483.
Wasmtime GitHub notifications bot (Nov 05 2023 at 12:57):badeend updated PR #7483.
Wasmtime GitHub notifications bot (Nov 05 2023 at 13:11):badeend updated PR #7483.
Wasmtime GitHub notifications bot (Nov 05 2023 at 21:36):alexcrichton submitted PR review:
Thanks!
We can add some code to the test later on if the resolution fails to try to cover up anything spurious that might show up
Wasmtime GitHub notifications bot (Nov 06 2023 at 18:50):badeend updated PR #7483.
Wasmtime GitHub notifications bot (Nov 06 2023 at 18:56):alexcrichton has enabled auto merge for PR #7483.
Wasmtime GitHub notifications bot (Nov 06 2023 at 20:11):alexcrichton merged PR #7483.
Last updated: Oct 23 2024 at 20:03 UTC