badeend opened PR #7483 from badeend:simplify-ip-name-lookup
to bytecodealliance:main
:
Simplify ip name lookup interface:
- Remove the non-essential parameters for now. Post-preview2 these can be reevaluated again.
- Lift the restriction against parsing IP addresses. Before, implementations still needed to parse IP addresses to decide whether or not to return an error.
Related: https://github.com/bytecodealliance/wasmtime/issues/7013
FYI, the test includes a lookup to
münchen.de
to test for internationalized domain names support. But it might be a bit weird to query this random, non-affiliated DNS server in the wasmtime CI. I tried looking for a standard testdomain (like example.com), but couldn't find any.
badeend requested wasmtime-core-reviewers for a review on PR #7483.
badeend requested fitzgen for a review on PR #7483.
badeend updated PR #7483.
badeend updated PR #7483.
alexcrichton submitted PR review:
Thanks!
We can add some code to the test later on if the resolution fails to try to cover up anything spurious that might show up
badeend updated PR #7483.
alexcrichton has enabled auto merge for PR #7483.
alexcrichton merged PR #7483.
Last updated: Dec 23 2024 at 13:07 UTC