Wasmtime GitHub notifications bot (Nov 02 2023 at 16:59): Wasmtime GitHub notifications bot (Nov 02 2023 at 16:59):alexcrichton opened PR #7459 from alexcrichton:components-cow to bytecodealliance:main:
This commit fixes a mistake in component compilation where copy-on-write and lazy initialization of function tables was accidentally not performed. I believe this is an accidental regression from a previous refactor, and this commit now ensures that the shared infrastructure between components and core modules accounts for copy-on-write and lazy table initialization.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 02 2023 at 16:59):alexcrichton requested fitzgen for a review on PR #7459.
Wasmtime GitHub notifications bot (Nov 02 2023 at 16:59):alexcrichton requested wasmtime-core-reviewers for a review on PR #7459.
Wasmtime GitHub notifications bot (Nov 03 2023 at 16:19):fitzgen submitted PR review:
Any way we can write a regression test here?
Wasmtime GitHub notifications bot (Nov 03 2023 at 16:52):alexcrichton updated PR #7459.
Wasmtime GitHub notifications bot (Nov 03 2023 at 16:53):alexcrichton has enabled auto merge for PR #7459.
Wasmtime GitHub notifications bot (Nov 03 2023 at 18:11):alexcrichton merged PR #7459.
Last updated: Dec 23 2024 at 12:05 UTC