Stream: git-wasmtime

Topic: wasmtime / PR #7455 Print the error from the wasi-http in...

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2023 at 16:37):

JakeChampion requested wasmtime-core-reviewers for a review on PR #7455.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2023 at 16:37):

JakeChampion requested pchickey for a review on PR #7455.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2023 at 16:37):

JakeChampion opened PR #7455 from JakeChampion:print-serve-error to bytecodealliance:main:

Prior to this change, the error was never printed out, making it a challenge to figure out what caused the error

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2023 at 18:31):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2023 at 18:31):

elliottt created PR review comment:

You can probably remove the annotation on Ok, now that there's an explicit Err use.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2023 at 18:35):

elliottt submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2023 at 18:35):

elliottt created PR review comment:

What do you think about this instead of eprintln?

                log::error!("[{req_id}] :: {:?}", e);

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2023 at 18:36):

elliottt edited PR review comment.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2023 at 18:38):

elliottt submitted PR review:

I like this change! I had one comment about using log::error! instead of eprintln!.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2023 at 23:12):

JakeChampion updated PR #7455.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2023 at 23:13):

JakeChampion created PR review comment:

            Ok(())

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2023 at 23:13):

JakeChampion submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2023 at 23:13):

JakeChampion updated PR #7455.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 02 2023 at 23:13):

JakeChampion requested elliottt for a review on PR #7455.

view this post on Zulip Wasmtime GitHub notifications bot (Nov 03 2023 at 20:05):

elliottt merged PR #7455.

Last updated: Nov 22 2024 at 17:03 UTC