JakeChampion requested wasmtime-core-reviewers for a review on PR #7455.
JakeChampion requested pchickey for a review on PR #7455.
JakeChampion opened PR #7455 from JakeChampion:print-serve-error
to bytecodealliance:main
:
Prior to this change, the error was never printed out, making it a challenge to figure out what caused the error
elliottt submitted PR review.
elliottt created PR review comment:
You can probably remove the annotation on
Ok
, now that there's an explicitErr
use.
elliottt submitted PR review.
elliottt created PR review comment:
What do you think about this instead of
eprintln
?log::error!("[{req_id}] :: {:?}", e);
elliottt edited PR review comment.
elliottt submitted PR review:
I like this change! I had one comment about using
log::error!
instead ofeprintln!
.
JakeChampion updated PR #7455.
JakeChampion created PR review comment:
Ok(())
JakeChampion submitted PR review.
JakeChampion updated PR #7455.
JakeChampion requested elliottt for a review on PR #7455.
elliottt merged PR #7455.
Last updated: Dec 23 2024 at 12:05 UTC