Stream: git-wasmtime

Topic: wasmtime / PR #7452 aarch64: Add support for `tbz` and `t...

Wasmtime GitHub notifications bot (Nov 02 2023 at 04:13):

alexcrichton opened PR #7452 from alexcrichton:aarch64-tbz-tbnz to bytecodealliance:main:

I noticed these instructions when glancing at some disassembly for other code and also noticed that Cranelift didn't have support for them. This adds a few new lowerings for conditional branches in the aarch64 backend which are for testing a bit and branching if it's zero or not zero.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 02 2023 at 04:13):

alexcrichton requested cfallin for a review on PR #7452.

Wasmtime GitHub notifications bot (Nov 02 2023 at 04:13):

alexcrichton requested wasmtime-compiler-reviewers for a review on PR #7452.

Wasmtime GitHub notifications bot (Nov 02 2023 at 15:55):

fitzgen submitted PR review:

r=me with comments addressed

Wasmtime GitHub notifications bot (Nov 02 2023 at 15:55):

fitzgen submitted PR review:

r=me with comments addressed

Wasmtime GitHub notifications bot (Nov 02 2023 at 15:55):

fitzgen created PR review comment:

;; Helper for emitting `MInst.TestBitAndBranch` instructions.

Wasmtime GitHub notifications bot (Nov 02 2023 at 15:55):

fitzgen created PR review comment:

Maybe name this TestBitAndBranch? Because cbz is already "test (compare) and branch" and the unique thing about tbz is that it is testing a bit.

Wasmtime GitHub notifications bot (Nov 02 2023 at 15:55):

fitzgen created PR review comment:

And can you add a test to emit_tests.rs for this new instruction format?

Wasmtime GitHub notifications bot (Nov 02 2023 at 15:55):

fitzgen created PR review comment:

Can we call this complement? That's what we call the IntCC version after a bunch of bike shedding names.

Wasmtime GitHub notifications bot (Nov 02 2023 at 15:55):

fitzgen created PR review comment:

Similar regarding naming

Wasmtime GitHub notifications bot (Nov 02 2023 at 21:30):

alexcrichton updated PR #7452.

Wasmtime GitHub notifications bot (Nov 02 2023 at 21:30):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Nov 02 2023 at 21:30):

alexcrichton created PR review comment:

Would you be ok omitting that? I personally find the emit_tests.rs files onerous and unwieldy to update when the golden tests serve basically the same purpose and are much easier to work with.

Wasmtime GitHub notifications bot (Nov 02 2023 at 22:10):

fitzgen submitted PR review.

Wasmtime GitHub notifications bot (Nov 02 2023 at 22:10):

fitzgen created PR review comment:

Sure

Wasmtime GitHub notifications bot (Nov 03 2023 at 01:31):

alexcrichton merged PR #7452.

Last updated: Dec 23 2024 at 13:07 UTC