Wasmtime GitHub notifications bot (Nov 02 2023 at 02:44): Wasmtime GitHub notifications bot (Nov 02 2023 at 02:44):elliottt opened PR #7451 from elliottt:trevor/validation-error-type to bytecodealliance:main:
Rename the
header-errorvariant tovalidation-error, and use that variant as the error value for all setters ofoutbound-requestandoutbound-response. This ensures that we have the opportunity to validate outbound request and response values before they're given to their respective handlers.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 02 2023 at 02:44):elliottt requested alexcrichton for a review on PR #7451.
Wasmtime GitHub notifications bot (Nov 02 2023 at 02:44):elliottt requested wasmtime-core-reviewers for a review on PR #7451.
Wasmtime GitHub notifications bot (Nov 02 2023 at 02:45):elliottt requested pchickey for a review on PR #7451.
Wasmtime GitHub notifications bot (Nov 02 2023 at 02:48):elliottt updated PR #7451.
Wasmtime GitHub notifications bot (Nov 02 2023 at 02:48):elliottt edited PR #7451:
Rename the
header-errorvariant tovalidation-error, and use that variant as the error value for all setters ofoutbound-requestandoutbound-response. This ensures that we have the opportunity to validate outbound request and response values before they're given to their respective handlers.Validation for uri components is done by using
http:uri::Builderwith only that value, ensuring that we don't raise an error. Validation for method and scheme is only done for theOthercases, and is accomplished by using the fallible parsers for each type from thehttpcrate.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 02 2023 at 03:13):elliottt updated PR #7451.
Wasmtime GitHub notifications bot (Nov 02 2023 at 07:13):elliottt updated PR #7451.
Wasmtime GitHub notifications bot (Nov 02 2023 at 07:20):elliottt updated PR #7451.
Wasmtime GitHub notifications bot (Nov 03 2023 at 16:39):elliottt updated PR #7451.
Wasmtime GitHub notifications bot (Nov 03 2023 at 18:04):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Nov 03 2023 at 18:04):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Nov 03 2023 at 18:04):pchickey created PR review comment:
Only feedback on this PR is that the wit docs here should describe that the set fails iff the value given is syntactically invalid.
Wasmtime GitHub notifications bot (Nov 03 2023 at 18:04):pchickey edited PR review comment.
Wasmtime GitHub notifications bot (Nov 03 2023 at 18:05):elliottt updated PR #7451.
Wasmtime GitHub notifications bot (Nov 03 2023 at 18:07):elliottt updated PR #7451.
Wasmtime GitHub notifications bot (Nov 03 2023 at 18:08):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Nov 03 2023 at 18:08):pchickey has enabled auto merge for PR #7451.
Wasmtime GitHub notifications bot (Nov 03 2023 at 18:14):elliottt updated PR #7451.
Wasmtime GitHub notifications bot (Nov 03 2023 at 22:12):elliottt requested fitzgen for a review on PR #7451.
Wasmtime GitHub notifications bot (Nov 03 2023 at 22:12):elliottt requested wasmtime-compiler-reviewers for a review on PR #7451.
Wasmtime GitHub notifications bot (Nov 03 2023 at 22:12):elliottt requested wasmtime-default-reviewers for a review on PR #7451.
Wasmtime GitHub notifications bot (Nov 03 2023 at 22:12):elliottt updated PR #7451.
Wasmtime GitHub notifications bot (Nov 03 2023 at 22:12):github-merge-queue[bot] updated PR #7451.
Wasmtime GitHub notifications bot (Nov 03 2023 at 22:52):elliottt updated PR #7451.
Wasmtime GitHub notifications bot (Nov 03 2023 at 22:54):pchickey has enabled auto merge for PR #7451.
Wasmtime GitHub notifications bot (Nov 03 2023 at 23:59):pchickey merged PR #7451.
Last updated: Nov 22 2024 at 16:03 UTC