Stream: git-wasmtime

Topic: wasmtime / PR #7447 Validate the status code in outgoing-...

Wasmtime GitHub notifications bot (Nov 01 2023 at 16:52):

elliottt opened PR #7447 from elliottt:trevor/fallible-response-set-status-code to bytecodealliance:main:

Validate the status-code given to outoging-reponse in wasi-http. This forces two changes to the interface:

• The constructor can no longer take a status-code argument, as there's no way to indicate errors from a constructor. The solution here is to default the status-code to 200, and use outgoing-response.set-status-code to change it when necessary.
• The outgoing-response.set-status-code method has become fallible, allowing us to indicate to the guest when an invalid status-code has been given.

Internally, the change to the wasmtime-wasi-http crate is that we're now storing an http::StatusCode instead of a raw u16.
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 01 2023 at 16:52):

elliottt requested fitzgen for a review on PR #7447.

Wasmtime GitHub notifications bot (Nov 01 2023 at 16:52):

elliottt requested wasmtime-core-reviewers for a review on PR #7447.

Wasmtime GitHub notifications bot (Nov 01 2023 at 16:53):

elliottt edited PR #7447:

Validate the status-code given to outoging-reponse in wasi-http. This forces two changes to the interface:

• The constructor can no longer take a status-code argument, as there's no way to indicate errors from a constructor. The solution here is to default the status-code to 200, and use outgoing-response.set-status-code to change it when necessary.
• The outgoing-response.set-status-code method has become fallible, allowing us to indicate to the guest when an invalid status-code has been given.

Internally, the change to the wasmtime-wasi-http crate is that we're now storing an http::StatusCode instead of a raw u16.

cc @JakeChampion
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Nov 01 2023 at 16:53):

elliottt requested pchickey for a review on PR #7447.

Wasmtime GitHub notifications bot (Nov 01 2023 at 17:02):

JakeChampion submitted PR review.

Wasmtime GitHub notifications bot (Nov 01 2023 at 17:06):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Nov 01 2023 at 17:16):

elliottt has enabled auto merge for PR #7447.

Wasmtime GitHub notifications bot (Nov 01 2023 at 18:04):

elliottt merged PR #7447.

Last updated: Nov 22 2024 at 17:03 UTC