Wasmtime GitHub notifications bot (Nov 01 2023 at 05:04): Wasmtime GitHub notifications bot (Nov 01 2023 at 05:04):cfallin requested pchickey for a review on PR #7436.
Wasmtime GitHub notifications bot (Nov 01 2023 at 05:04):cfallin opened PR #7436 from cfallin:fix-ansi-color-sequences to bytecodealliance:main:
In #7239 we added a
tracing-logsubscriber that prints logs to stderr if enabled with an environment variable. It included logic to add ANSI color sequences when stderr is a terminal, for legibility. Unfortunately it seems that while this logic enabled colors on a terminal, it did not disable colors on a non-terminal; so redirects of stderr to a file would result in ANSI color sequences being captured in that file. Specifically, the builder seems not to default to no-color; so rather than enable-or-nothing, we should explicitly enable or disable always.Fixes #7435.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 01 2023 at 05:04):cfallin requested wasmtime-core-reviewers for a review on PR #7436.
Wasmtime GitHub notifications bot (Nov 01 2023 at 14:34):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Nov 01 2023 at 17:29):fitzgen merged PR #7436.
Last updated: Dec 23 2024 at 13:07 UTC