Wasmtime GitHub notifications bot (Nov 01 2023 at 00:30): Wasmtime GitHub notifications bot (Nov 01 2023 at 00:30):elliottt opened PR #7434 from elliottt:trevor/wasi-http-errors to bytecodealliance:main:
Start integrating the more descriptive error variant present in https://github.com/WebAssembly/wasi-http/pull/52.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 01 2023 at 00:31):elliottt edited PR #7434:
Start integrating the more descriptive error variant present in https://github.com/WebAssembly/wasi-http/pull/52.
Fixes #7248
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 01 2023 at 01:30):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 01 2023 at 23:08):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 02 2023 at 00:04):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 02 2023 at 00:05):elliottt submitted PR review.
Wasmtime GitHub notifications bot (Nov 02 2023 at 00:05):elliottt created PR review comment:
This was preventing
downcast::<Error>()in test cases.
Wasmtime GitHub notifications bot (Nov 02 2023 at 00:06):elliottt edited PR #7434:
Integrate the more descriptive error variant present in https://github.com/WebAssembly/wasi-http/pull/52. This PR attempts to port the existing errors we raise directly to the new variant.
Fixes #7248
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Nov 02 2023 at 00:27):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 02 2023 at 00:27):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 02 2023 at 07:14):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 02 2023 at 16:01):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 02 2023 at 19:34):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 03 2023 at 22:23):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 03 2023 at 22:53):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 07 2023 at 21:02):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 07 2023 at 21:10):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 07 2023 at 21:47):elliottt has marked PR #7434 as ready for review.
Wasmtime GitHub notifications bot (Nov 07 2023 at 21:47):elliottt requested fitzgen for a review on PR #7434.
Wasmtime GitHub notifications bot (Nov 07 2023 at 21:47):elliottt requested wasmtime-core-reviewers for a review on PR #7434.
Wasmtime GitHub notifications bot (Nov 07 2023 at 22:35):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 07 2023 at 23:35):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 07 2023 at 23:39):elliottt requested pchickey for a review on PR #7434.
Wasmtime GitHub notifications bot (Nov 09 2023 at 01:25):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 10 2023 at 06:52):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 10 2023 at 20:01):pchickey submitted PR review.
Wasmtime GitHub notifications bot (Nov 10 2023 at 21:12):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 10 2023 at 21:46):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 10 2023 at 21:46):elliottt has enabled auto merge for PR #7434.
Wasmtime GitHub notifications bot (Nov 11 2023 at 00:06):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 11 2023 at 00:19):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 11 2023 at 00:42):elliottt updated PR #7434.
Wasmtime GitHub notifications bot (Nov 11 2023 at 06:43):elliottt merged PR #7434.
Last updated: Nov 22 2024 at 17:03 UTC