Stream: git-wasmtime

Topic: wasmtime / PR #7426 wasi-http: Hold the incoming body wor...

Wasmtime GitHub notifications bot (Oct 31 2023 at 17:24):

elliottt requested pchickey for a review on PR #7426.

Wasmtime GitHub notifications bot (Oct 31 2023 at 17:24):

elliottt opened PR #7426 from elliottt:trevor/fix-7413 to bytecodealliance:main:

Hold the handle to the worker task in an Arc to allow us to keep the worker alive through either the HostIncomingResponse or the HostIncomingBody values that manage it through its lifetime.

Fixes #7413
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 31 2023 at 17:24):

elliottt requested wasmtime-core-reviewers for a review on PR #7426.

Wasmtime GitHub notifications bot (Oct 31 2023 at 17:26):

elliottt edited PR #7426:

Hold the handle to the worker task in an Arc to allow us to keep the worker alive through either the HostIncomingResponse or the HostIncomingBody values that manage it through its lifetime.

I tested this by adding the drop call that @dicej mentioned in #7413 on #7412, and verifying that the test now passes.

Fixes #7413
<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 31 2023 at 17:26):

elliottt requested dicej for a review on PR #7426.

Wasmtime GitHub notifications bot (Oct 31 2023 at 17:54):

dicej submitted PR review:

Thanks, @elliottt!

Wasmtime GitHub notifications bot (Oct 31 2023 at 18:43):

pchickey merged PR #7426.

Last updated: Dec 23 2024 at 12:05 UTC