Wasmtime GitHub notifications bot (Oct 31 2023 at 16:14): Wasmtime GitHub notifications bot (Oct 31 2023 at 16:14):badeend opened PR #7423 from badeend:udp-tests to bytecodealliance:main:
No major functional changes:
- Moved the validation utility methods out of tcp.rs and into network.rs so that the UDP implementation can use them too.
- Extracted most platform compatibility fixes out into separate functions and moved them to a place where they can be used by UDP too.
- Applied those validations and compatibility fixes to the UDP implementation as well.
- Copied the TCP tests and adjusted them to work with UDP
Wasmtime GitHub notifications bot (Oct 31 2023 at 16:14):badeend requested alexcrichton for a review on PR #7423.
Wasmtime GitHub notifications bot (Oct 31 2023 at 16:14):badeend requested wasmtime-core-reviewers for a review on PR #7423.
Wasmtime GitHub notifications bot (Oct 31 2023 at 16:33):alexcrichton submitted PR review:
Thanks!
Sort of a side-question as it's not directly related to this PR itself, where's all this error-handling code coming from? This seems extensive enough that the tests probably aren't exercising all the various cases here and I'm curious if you're porting from another library for example or something like that.
Wasmtime GitHub notifications bot (Oct 31 2023 at 16:33):alexcrichton submitted PR review:
Thanks!
Sort of a side-question as it's not directly related to this PR itself, where's all this error-handling code coming from? This seems extensive enough that the tests probably aren't exercising all the various cases here and I'm curious if you're porting from another library for example or something like that.
Wasmtime GitHub notifications bot (Oct 31 2023 at 16:33):alexcrichton created PR review comment:
Can this fail if the port is already bound? We've had issues with tests running concurrently in the past and I think the TCP test has a case where it handles failure to bind here.
Wasmtime GitHub notifications bot (Oct 31 2023 at 19:13):badeend submitted PR review.
Wasmtime GitHub notifications bot (Oct 31 2023 at 19:13):badeend created PR review comment:
Ah right. Hadn't noticed the TCP test changed recently. Yes, this UDP test needs the same update.
Wasmtime GitHub notifications bot (Nov 04 2023 at 19:39):badeend updated PR #7423.
Wasmtime GitHub notifications bot (Nov 04 2023 at 19:40):badeend submitted PR review.
Wasmtime GitHub notifications bot (Nov 04 2023 at 19:40):badeend created PR review comment:
I've updated the test with the same workaround that's in the TCP test.
Wasmtime GitHub notifications bot (Nov 05 2023 at 22:15):alexcrichton merged PR #7423.
Last updated: Nov 22 2024 at 17:03 UTC