Wasmtime GitHub notifications bot (Oct 30 2023 at 21:33): Wasmtime GitHub notifications bot (Oct 30 2023 at 21:33):alexcrichton opened PR #7416 from alexcrichton:fix-double-colon-in-dir to bytecodealliance:main:
In Wasmtime 13 and prior the
--dirargument was unconditionally used to open a host dir as the same name and in the guest. In Wasmtime 14+ though this argument is being repurposed with an optional trailing::GUESTto configure the guest directory. This means that--dir-with-remapping behavior is actually unusable without the environment variable configuration from #7385 due to it parsing differently in the old and the new.This commit updates the situation by adding
::-parsing to the old CLI meaning that both the old and the new parse this the same way. This will break any scripts that open host directories with two colons in their path, but that seems niche enough we can handle that later.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Wasmtime GitHub notifications bot (Oct 30 2023 at 21:33):alexcrichton requested fitzgen for a review on PR #7416.
Wasmtime GitHub notifications bot (Oct 30 2023 at 21:33):alexcrichton requested wasmtime-core-reviewers for a review on PR #7416.
Wasmtime GitHub notifications bot (Oct 30 2023 at 23:51):fitzgen submitted PR review.
Wasmtime GitHub notifications bot (Oct 31 2023 at 00:34):fitzgen merged PR #7416.
Last updated: Nov 22 2024 at 17:03 UTC