Stream: git-wasmtime

Topic: wasmtime / PR #7410 egraphs: Avoid producing iconst.i128 ...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 30 2023 at 19:38):

afonso360 opened PR #7410 from afonso360:egraphs-iconst-i128 to bytecodealliance:main:

:wave: Hey,

This PR fixes an issue with an egraphs rule, where it could accidentally transform a icmp and produce a iconst.i128 along the way. The fix here is to disable this rule for i128.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 30 2023 at 19:38):

afonso360 requested abrown for a review on PR #7410.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 30 2023 at 19:38):

afonso360 requested wasmtime-compiler-reviewers for a review on PR #7410.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 30 2023 at 19:38):

afonso360 edited PR #7410:

:wave: Hey,

This PR fixes an issue with an egraphs rule, where it could accidentally transform a icmp and produce a iconst.i128 along the way. The fix here is to disable this rule for i128.

Fixes #7229

view this post on Zulip Wasmtime GitHub notifications bot (Oct 30 2023 at 19:41):

cfallin submitted PR review:

Thanks!

view this post on Zulip Wasmtime GitHub notifications bot (Oct 30 2023 at 19:41):

cfallin has enabled auto merge for PR #7410.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 30 2023 at 21:22):

alexcrichton merged PR #7410.

Last updated: Oct 23 2024 at 20:03 UTC