alexcrichton opened PR #7407 from alexcrichton:bump-wasm-tools
to bytecodealliance:main
:
This commit updates the wasm-tools family of crate for a number of notable updates:
- bytecodealliance/wasm-tools#1257 - wasmparser's ID-based infrastructure has been refactored to have more precise types for each ID rather than one all-purpose
TypeId
.- bytecodealliance/wasm-tools#1262 - the implementation of "implementation imports" for the component model which both updates the binary format in addition to adding more syntactic forms of imports.
- bytecodealliance/wasm-tools#1260 - a new encoding scheme for component information for
wit-component
in objects (not used by Wasmtime but used by bindings generators).Translation for components needed to be updated to account for the first change, but otherwise this was a straightforward update.
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton requested wasmtime-compiler-reviewers for a review on PR #7407.
alexcrichton requested cfallin for a review on PR #7407.
alexcrichton requested wasmtime-core-reviewers for a review on PR #7407.
alexcrichton requested fitzgen for a review on PR #7407.
alexcrichton requested wasmtime-default-reviewers for a review on PR #7407.
pchickey submitted PR review.
pchickey submitted PR review.
pchickey created PR review comment:
Never got back to this TODO?
alexcrichton updated PR #7407.
alexcrichton submitted PR review.
alexcrichton created PR review comment:
Oops yes, just needed to delete the code
alexcrichton submitted PR review.
alexcrichton created PR review comment:
For the curious, this TODO led to https://github.com/WebAssembly/component-model/issues/269
pchickey submitted PR review.
alexcrichton has enabled auto merge for PR #7407.
alexcrichton merged PR #7407.
Last updated: Dec 23 2024 at 12:05 UTC