Stream: git-wasmtime

Topic: wasmtime / PR #7405 Attempt to automatically configure re...

Wasmtime GitHub notifications bot (Oct 30 2023 at 16:47):

alexcrichton opened PR #7405 from alexcrichton:auto-relnotes to bytecodealliance:main:

This commit is an attempt to tackle #7068 by configuring the release notes in Github Releases with the handwritten release notes from RELEASES.md. The basic idea here is to split the markdown file on ----- delimiters and then find the one which matches the version being released. Once one is found the body field of the API call to create the release is configured.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 30 2023 at 16:47):

alexcrichton requested wasmtime-default-reviewers for a review on PR #7405.

Wasmtime GitHub notifications bot (Oct 30 2023 at 16:47):

alexcrichton requested abrown for a review on PR #7405.

Wasmtime GitHub notifications bot (Oct 30 2023 at 16:48):

alexcrichton edited PR #7405:

This commit is an attempt to tackle #7068 by configuring the release notes in Github Releases with the handwritten release notes from RELEASES.md. The basic idea here is to split the markdown file on ----- delimiters and then find the one which matches the version being released. Once one is found the body field of the API call to create the release is configured.

Closes https://github.com/bytecodealliance/wasmtime/issues/7068

Wasmtime GitHub notifications bot (Oct 30 2023 at 17:00):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Oct 30 2023 at 17:00):

abrown submitted PR review.

Wasmtime GitHub notifications bot (Oct 30 2023 at 17:00):

abrown created PR review comment:

Do we need to be more defensive? What about lists that start a line with - or a -- that somehow gets formatted to the beginning of a line?

      for (let x of releaseNotes.split(/^---+$/m)) {

Wasmtime GitHub notifications bot (Oct 30 2023 at 17:38):

alexcrichton updated PR #7405.

Wasmtime GitHub notifications bot (Oct 30 2023 at 17:38):

alexcrichton has enabled auto merge for PR #7405.

Wasmtime GitHub notifications bot (Oct 30 2023 at 18:56):

alexcrichton merged PR #7405.

Last updated: Nov 22 2024 at 17:03 UTC