Stream: git-wasmtime

Topic: wasmtime / PR #7402 Don't panic in `wasmtime serve` when ...

Wasmtime GitHub notifications bot (Oct 30 2023 at 15:24):

alexcrichton requested elliottt for a review on PR #7402.

Wasmtime GitHub notifications bot (Oct 30 2023 at 15:24):

alexcrichton requested fitzgen for a review on PR #7402.

Wasmtime GitHub notifications bot (Oct 30 2023 at 15:24):

alexcrichton requested wasmtime-core-reviewers for a review on PR #7402.

Wasmtime GitHub notifications bot (Oct 30 2023 at 15:24):

alexcrichton opened PR #7402 from alexcrichton:fix-panic to bytecodealliance:main:

This commit fixes a panic in the wasmtime serve CLI command when the response-outparam::set method was never invoked by the guest. In this situation return a more first-class error than a panic explaining what the guest should be doing.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 30 2023 at 15:35):

fitzgen submitted PR review:

CLI test?

Wasmtime GitHub notifications bot (Oct 30 2023 at 17:10):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Oct 30 2023 at 17:41):

alexcrichton merged PR #7402.

Last updated: Dec 23 2024 at 12:05 UTC