Stream: git-wasmtime

Topic: wasmtime / PR #7394 Fix file writes in preview 2 implemen...

Wasmtime GitHub notifications bot (Oct 31 2023 at 16:17):

pchickey edited PR #7394:

Fixes #7390

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 31 2023 at 16:18):

pchickey edited PR #7394:

In https://github.com/bytecodealliance/wasmtime/pull/7130, there was a regression introduced in FileOutputStream where the position cursor was not updated after each write. This affects all file writes except for when the file is opened for appending.

This PR also adds a test which performs a larger (64k) write to a file than any prior tests.

Fixes #7390

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 31 2023 at 16:18):

pchickey has marked PR #7394 as ready for review.

Wasmtime GitHub notifications bot (Oct 31 2023 at 16:18):

pchickey requested wasmtime-core-reviewers for a review on PR #7394.

Wasmtime GitHub notifications bot (Oct 31 2023 at 16:18):

pchickey requested fitzgen for a review on PR #7394.

Wasmtime GitHub notifications bot (Oct 31 2023 at 16:18):

pchickey requested alexcrichton for a review on PR #7394.

Wasmtime GitHub notifications bot (Oct 31 2023 at 16:24):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 31 2023 at 17:10):

alexcrichton merged PR #7394.

Wasmtime GitHub notifications bot (Nov 15 2023 at 19:08):

ricochet assigned PR #7394 to pchickey.

Last updated: Nov 22 2024 at 17:03 UTC