elliottt opened PR #7388 from elliottt:trevor/simple-stdio
to bytecodealliance:main
:
Use blocking IO for stdout and stderr
HostOutputStream
implementations. The reasoning here is that these should never block unless something outside of our control is failing to consume the streams.
elliottt updated PR #7388.
elliottt has marked PR #7388 as ready for review.
elliottt requested fitzgen for a review on PR #7388.
elliottt requested wasmtime-core-reviewers for a review on PR #7388.
elliottt requested pchickey for a review on PR #7388.
elliottt requested alexcrichton for a review on PR #7388.
pchickey submitted PR review:
LGTM modulo adding some comments as we discussed! Thanks for figuring this mess out.
alexcrichton submitted PR review.
elliottt updated PR #7388.
elliottt edited PR #7388:
Use blocking IO for stdout and stderr
HostOutputStream
implementations. The reasoning here is that these should never block unless something outside of our control is failing to consume the streams.This doesn't resolve #7258, but it does take the immediate pressure off, as the only instance of it was
stdout
andstderr
.
elliottt merged PR #7388.
Last updated: Dec 23 2024 at 12:05 UTC