Stream: git-wasmtime

Topic: wasmtime / PR #7388 preview2: Use blocking io for stdout ...

Wasmtime GitHub notifications bot (Oct 27 2023 at 00:01):

elliottt opened PR #7388 from elliottt:trevor/simple-stdio to bytecodealliance:main:

Use blocking IO for stdout and stderr HostOutputStream implementations. The reasoning here is that these should never block unless something outside of our control is failing to consume the streams.

Wasmtime GitHub notifications bot (Oct 27 2023 at 01:58):

elliottt updated PR #7388.

Wasmtime GitHub notifications bot (Oct 31 2023 at 21:33):

elliottt has marked PR #7388 as ready for review.

Wasmtime GitHub notifications bot (Oct 31 2023 at 21:33):

elliottt requested fitzgen for a review on PR #7388.

Wasmtime GitHub notifications bot (Oct 31 2023 at 21:33):

elliottt requested wasmtime-core-reviewers for a review on PR #7388.

Wasmtime GitHub notifications bot (Oct 31 2023 at 21:33):

elliottt requested pchickey for a review on PR #7388.

Wasmtime GitHub notifications bot (Oct 31 2023 at 21:33):

elliottt requested alexcrichton for a review on PR #7388.

Wasmtime GitHub notifications bot (Oct 31 2023 at 21:34):

pchickey submitted PR review:

LGTM modulo adding some comments as we discussed! Thanks for figuring this mess out.

Wasmtime GitHub notifications bot (Oct 31 2023 at 21:46):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 31 2023 at 22:23):

elliottt updated PR #7388.

Wasmtime GitHub notifications bot (Oct 31 2023 at 22:24):

elliottt edited PR #7388:

Use blocking IO for stdout and stderr HostOutputStream implementations. The reasoning here is that these should never block unless something outside of our control is failing to consume the streams.

This doesn't resolve #7258, but it does take the immediate pressure off, as the only instance of it was stdout and stderr.

Wasmtime GitHub notifications bot (Nov 01 2023 at 01:04):

elliottt merged PR #7388.

Last updated: Nov 22 2024 at 16:03 UTC