Stream: git-wasmtime

Topic: wasmtime / PR #7379 Add float comparison operators to Winch

Wasmtime GitHub notifications bot (Oct 26 2023 at 14:44):

jeffcharles opened PR #7379 from jeffcharles:winch-float-comparisons to bytecodealliance:main:

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Part of #6528. Adds support for the f32.eq, f64.eq, f32.ne, f64.ne, f32.lt, f64.lt, f32.gt, f64.gt, f32.le, f64.le, f32.ge, and f64.ge operators to Winch.

Also renames the macroassembler CmpKind enum to IntCmpKind due to the introduction of a FloatCmpKind enum.

Wasmtime GitHub notifications bot (Oct 26 2023 at 14:44):

jeffcharles requested elliottt for a review on PR #7379.

Wasmtime GitHub notifications bot (Oct 26 2023 at 14:44):

jeffcharles requested wasmtime-fuzz-reviewers for a review on PR #7379.

Wasmtime GitHub notifications bot (Oct 26 2023 at 14:44):

jeffcharles requested wasmtime-compiler-reviewers for a review on PR #7379.

Wasmtime GitHub notifications bot (Oct 26 2023 at 14:44):

jeffcharles requested alexcrichton for a review on PR #7379.

Wasmtime GitHub notifications bot (Oct 26 2023 at 14:44):

jeffcharles requested wasmtime-core-reviewers for a review on PR #7379.

Wasmtime GitHub notifications bot (Oct 26 2023 at 14:50):

alexcrichton requested saulecabrera for a review on PR #7379.

Wasmtime GitHub notifications bot (Oct 26 2023 at 15:55):

saulecabrera submitted PR review:

Looks good to me overall -- one minor documentation change and I think we can land this.

Wasmtime GitHub notifications bot (Oct 26 2023 at 15:55):

saulecabrera submitted PR review:

Looks good to me overall -- one minor documentation change and I think we can land this.

Wasmtime GitHub notifications bot (Oct 26 2023 at 15:55):

saulecabrera created PR review comment:

Can we add a comment here explaining why we use the comp kind complement? (e.g. Ge => LeU)

Wasmtime GitHub notifications bot (Oct 26 2023 at 18:40):

jeffcharles updated PR #7379.

Wasmtime GitHub notifications bot (Oct 26 2023 at 18:43):

saulecabrera has enabled auto merge for PR #7379.

Wasmtime GitHub notifications bot (Oct 26 2023 at 18:43):

jeffcharles submitted PR review.

Wasmtime GitHub notifications bot (Oct 26 2023 at 18:43):

jeffcharles created PR review comment:

Yeah that's fair. I realized when writing the comments that we only need to perform the complementary comparisons for lt and le given we need to have the PF checks for gt and ge so we're not saving any instructions by swapping those so we no longer swap those.

Wasmtime GitHub notifications bot (Oct 26 2023 at 19:58):

saulecabrera merged PR #7379.

Last updated: Nov 22 2024 at 17:03 UTC