jeffcharles opened PR #7379 from jeffcharles:winch-float-comparisons
to bytecodealliance:main
:
<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
Part of #6528. Adds support for thef32.eq
,f64.eq
,f32.ne
,f64.ne
,f32.lt
,f64.lt
,f32.gt
,f64.gt
,f32.le
,f64.le
,f32.ge
, andf64.ge
operators to Winch.Also renames the macroassembler
CmpKind
enum toIntCmpKind
due to the introduction of aFloatCmpKind
enum.
jeffcharles requested elliottt for a review on PR #7379.
jeffcharles requested wasmtime-fuzz-reviewers for a review on PR #7379.
jeffcharles requested wasmtime-compiler-reviewers for a review on PR #7379.
jeffcharles requested alexcrichton for a review on PR #7379.
jeffcharles requested wasmtime-core-reviewers for a review on PR #7379.
alexcrichton requested saulecabrera for a review on PR #7379.
saulecabrera submitted PR review:
Looks good to me overall -- one minor documentation change and I think we can land this.
saulecabrera submitted PR review:
Looks good to me overall -- one minor documentation change and I think we can land this.
saulecabrera created PR review comment:
Can we add a comment here explaining why we use the comp kind complement? (e.g.
Ge => LeU
)
jeffcharles updated PR #7379.
saulecabrera has enabled auto merge for PR #7379.
jeffcharles submitted PR review.
jeffcharles created PR review comment:
Yeah that's fair. I realized when writing the comments that we only need to perform the complementary comparisons for
lt
andle
given we need to have the PF checks forgt
andge
so we're not saving any instructions by swapping those so we no longer swap those.
saulecabrera merged PR #7379.
Last updated: Dec 23 2024 at 12:05 UTC