Wasmtime GitHub notifications bot (Oct 25 2023 at 23:26): Wasmtime GitHub notifications bot (Oct 25 2023 at 23:26):abrown requested pchickey for a review on PR #7376.
Wasmtime GitHub notifications bot (Oct 25 2023 at 23:26):abrown requested wasmtime-core-reviewers for a review on PR #7376.
Wasmtime GitHub notifications bot (Oct 25 2023 at 23:26):abrown opened PR #7376 from abrown:pku-more-tests to bytecodealliance:main:
See the commit messages for more details, but in summary:
- this adds a test checking that the MPK boundary checks are happening
- this disables MPK for tests that rely on a certain slot to store ratio
With this change,
ci/run-tests.shruns locally on an MPK-enabled machine with MPK turned on. There is more work to be done before MPK can be turned on by default (see https://github.com/bytecodealliance/wasmtime/issues/7119) but this helps.
Wasmtime GitHub notifications bot (Oct 25 2023 at 23:26):abrown edited PR #7376:
See the commit messages for more details, but in summary:
- this adds a test checking that the MPK boundary checks are happening
- this disables MPK for tests that rely on a specific slot-to-store ratio
With this change,
ci/run-tests.shruns locally on an MPK-enabled machine with MPK turned on. There is more work to be done before MPK can be turned on by default (see https://github.com/bytecodealliance/wasmtime/issues/7119) but this helps.
Wasmtime GitHub notifications bot (Oct 26 2023 at 14:05):alexcrichton submitted PR review.
Wasmtime GitHub notifications bot (Oct 26 2023 at 14:57):alexcrichton merged PR #7376.
Last updated: Dec 23 2024 at 12:05 UTC