Stream: git-wasmtime

Topic: wasmtime / PR #7374 `cranelift-wasm`: Add a small optimiz...

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2023 at 21:44):

fitzgen edited PR #7374:

In this case, we don't need to load the dynamic heap bound from the vmctx
because it actually has a constant size. Instead, we can use the constant
directly.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2023 at 21:46):

alexcrichton submitted PR review:

Mind adding a test for a (memory 1 2) as well to ensure that a constant size isn't used?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2023 at 21:48):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2023 at 21:48):

fitzgen created PR review comment:

Might be better to and_then instead of map here actually and not swap out the max for u64::MAX on overflow?

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2023 at 21:48):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2023 at 21:56):

fitzgen submitted PR review.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2023 at 21:56):

fitzgen created PR review comment:

Done.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2023 at 21:57):

fitzgen updated PR #7374.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2023 at 21:58):

fitzgen has enabled auto merge for PR #7374.

view this post on Zulip Wasmtime GitHub notifications bot (Oct 25 2023 at 23:17):

fitzgen merged PR #7374.

Last updated: Nov 22 2024 at 16:03 UTC