Stream: git-wasmtime

Topic: wasmtime / PR #7361 [release-13.0] Backport removal of `p...

Wasmtime GitHub notifications bot (Oct 25 2023 at 16:46):

ulan requested fitzgen for a review on PR #7361.

Wasmtime GitHub notifications bot (Oct 25 2023 at 16:46):

ulan opened PR #7361 from ulan:fix-release-13.0.0 to bytecodealliance:release-13.0.0:

Remove the leftover usage of posix-signals-on-macos (#7360)

This follows up #6807 and removes the last remaining reference to the removed posix-signals-on-macos feature flag.

Note that lib.rs now imports mod unix on MacOS. This change is similar to the change in traphandlers.rs in #6807. It is needed for hosts that use signals instead of Mach ports on MacOs.

<!--
Please make sure you include the following information:

• If this work has been discussed elsewhere, please include a link to that
  conversation. If it was discussed in an issue, just mention "issue #...".

• Explain why this change is needed. If the details are in an issue already,
  this can be brief.

Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.html

Please ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->

Wasmtime GitHub notifications bot (Oct 25 2023 at 16:46):

ulan requested wasmtime-core-reviewers for a review on PR #7361.

Wasmtime GitHub notifications bot (Oct 25 2023 at 19:09):

alexcrichton updated PR #7361.

Wasmtime GitHub notifications bot (Oct 25 2023 at 19:09):

alexcrichton requested wasmtime-default-reviewers for a review on PR #7361.

Wasmtime GitHub notifications bot (Oct 25 2023 at 19:10):

alexcrichton submitted PR review:

I pushed up a cherry-pick which I think will fix the CI failure from prior

Wasmtime GitHub notifications bot (Oct 25 2023 at 20:00):

alexcrichton merged PR #7361.

Last updated: Oct 23 2024 at 20:03 UTC