ulan requested wasmtime-core-reviewers for a review on PR #7360.
ulan requested pchickey for a review on PR #7360.
ulan opened PR #7360 from ulan:remove-leftover-posix-signals-on-macos
to bytecodealliance:main
:
This follows up #6807 and removes the last remaining reference to the removed
posix-signals-on-macos
feature flag.Note that
lib.rs
now importsmod unix
on MacOS. This change is similar to the change intraphandlers.rs
in #6807. It is needed for hosts that use signals instead of Mach ports on MacOs.<!--
Please make sure you include the following information:
If this work has been discussed elsewhere, please include a link to that
conversation. If it was discussed in an issue, just mention "issue #...".Explain why this change is needed. If the details are in an issue already,
this can be brief.Our development process is documented in the Wasmtime book:
https://docs.wasmtime.dev/contributing-development-process.htmlPlease ensure all communication follows the code of conduct:
https://github.com/bytecodealliance/wasmtime/blob/main/CODE_OF_CONDUCT.md
-->
alexcrichton submitted PR review:
Thanks for this!
alexcrichton has enabled auto merge for PR #7360.
alexcrichton merged PR #7360.
Last updated: Dec 23 2024 at 12:05 UTC