Stream: git-wasmtime

Topic: wasmtime / PR #7358 monotonic clock: introduce `duration`...

Wasmtime GitHub notifications bot (Oct 25 2023 at 00:55):

pchickey opened PR #7358 from bytecodealliance:pch/monotonic-clock-duration to bytecodealliance:main:

Implement the interface change submitted upstream as https://github.com/WebAssembly/wasi-clocks/pull/53

We are introducing a duration type because it has a distinct meaning
from instant: an instant can only be compared to other instants
from the exact same monotonic-clock, whereas a duration represents
a duration of time which can be compared to any other duration of time.

The duration type is motivated, in part, by a desire to reuse it to
specify durations such as timeouts in other WASI proposals.

Instead of taking a boolean specifying whether the u64 is an absolute or
relative time, subscribe-instant takes an instant type and
subscribe-duration takes a duration type.

Wasmtime GitHub notifications bot (Oct 25 2023 at 00:55):

pchickey requested alexcrichton for a review on PR #7358.

Wasmtime GitHub notifications bot (Oct 25 2023 at 00:55):

pchickey requested wasmtime-core-reviewers for a review on PR #7358.

Wasmtime GitHub notifications bot (Oct 25 2023 at 13:52):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 25 2023 at 13:52):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 25 2023 at 13:52):

alexcrichton created PR review comment:

Could this method perhaps delegate to subscribe_duration or a similar helper once it calculates the relative desired Duration? Or alternatively would it be possible to directly convert between when and a tokio::time::Instant?

It basically felt a bit odf that the Never case was handled below but not here

Wasmtime GitHub notifications bot (Oct 27 2023 at 22:24):

pchickey updated PR #7358.

Wasmtime GitHub notifications bot (Oct 27 2023 at 22:24):

pchickey submitted PR review.

Wasmtime GitHub notifications bot (Oct 27 2023 at 22:24):

pchickey created PR review comment:

Thanks, I thought that over again and factored it out into a helper function.

Wasmtime GitHub notifications bot (Oct 27 2023 at 22:24):

pchickey requested alexcrichton for a review on PR #7358.

Wasmtime GitHub notifications bot (Oct 27 2023 at 22:30):

pchickey updated PR #7358.

Wasmtime GitHub notifications bot (Oct 27 2023 at 23:41):

alexcrichton submitted PR review.

Wasmtime GitHub notifications bot (Oct 30 2023 at 21:25):

pchickey updated PR #7358.

Wasmtime GitHub notifications bot (Oct 30 2023 at 21:45):

pchickey has enabled auto merge for PR #7358.

Wasmtime GitHub notifications bot (Oct 30 2023 at 22:36):

pchickey merged PR #7358.

Last updated: Nov 22 2024 at 17:03 UTC